From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: Stefan Beller <sbeller@google•com>, gitster@pobox•com
Cc: john@keeping•me.uk, git@vger•kernel.org
Subject: Re: [PATCH] config doc: improve exit code listing
Date: Tue, 26 Apr 2016 20:11:14 +0100 [thread overview]
Message-ID: <571FBD52.4040206@ramsayjones.plus.com> (raw)
In-Reply-To: <20160426181058.7901-1-sbeller@google.com>
On 26/04/16 19:10, Stefan Beller wrote:
> The possible reasons for exiting are now ordered by the exit code value.
> While at it, rewrite the `can not write to the config file` to
> `the config file cannot be written` to be grammatically correct and a
> proper sentence.
>
> Signed-off-by: Stefan Beller <sbeller@google•com>
> ---
> Documentation/git-config.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 6fc08e3..6843114 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -58,10 +58,10 @@ that location (you can say '--local' but that is the default).
> This command will fail with non-zero status upon error. Some exit
> codes are:
>
> -- The config file is invalid (ret=3),
^
I don't see why this is capitalised, so ...
> -- can not write to the config file (ret=4),
> +- The section or key is invalid (ret=1),
^
I don't think you should transfer the capital here. ;-)
> - no section or name was provided (ret=2),
> -- the section or key is invalid (ret=1),
> +- the config file is invalid (ret=3),
> +- the config file cannot be written (ret=4),
> - you try to unset an option which does not exist (ret=5),
> - you try to unset/set an option for which multiple lines match (ret=5), or
> - you try to use an invalid regexp (ret=6).
>
Only a minor point.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-04-26 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 18:10 [PATCH] config doc: improve exit code listing Stefan Beller
2016-04-26 18:30 ` Junio C Hamano
2016-04-26 19:11 ` Ramsay Jones [this message]
2016-04-26 19:18 ` Stefan Beller
2016-04-26 19:41 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571FBD52.4040206@ramsayjones.plus.com \
--to=ramsay@ramsayjones$(echo .)plus.com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=john@keeping$(echo .)me.uk \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox