Subject: Re: [PATCH] xemit.c: fix a [-Wchar-subscripts] compiler warning

From: René Scharfe <[email-masked]>
Date: Thu, 26 May 2016 04:22:04 +0200

[sorry for duplicate]

Am 26.05.2016 um 01:06 schrieb Ramsay Jones:
>
> While compiling on cygwin (x86_64), gcc complains thus:
>
>        CC xdiff/xemit.o
>    xdiff/xemit.c: In function ‘is_empty_rec’:
>    xdiff/xemit.c:163:2: warning: array subscript has type ‘char’ [-Wchar-subscripts]
>      while (len > 0 && isspace(*rec)) {
>      ^

Ah, it's not using our own isspace(), which works fine with signed 
chars, because it doesn't include git-compat-util.h.  I'm spoilt by 
those char classifier macros that can be actually used with chars.. 
Thanks for catching!

René