From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Stefan Beller <sbeller@google•com>,
Nguyen Thai Ngoc Duy <pclouds@gmail•com>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: [RFC/PATCH] pathspec: allow escaped query values
Date: Thu, 2 Jun 2016 20:52:21 +0100 [thread overview]
Message-ID: <57508E75.8050501@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqmvn3tmnm.fsf@gitster.mtv.corp.google.com>
On 02/06/16 20:29, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox•com> writes:
>
>> On Thu, Jun 2, 2016 at 11:42 AM, Ramsay Jones
>> <ramsay@ramsayjones•plus.com> wrote:
>>>>
>>>> That would be workable, I would think. Before attr:VAR=VAL
>>>> extention, supported pathspec <magic> were only single lowercase-ascii
>>>> alphabet tokens, so nobody would have used " as a part of magic. So
>>>> quting with double-quote pair would work.
>>>
>>> I was thinking about both ' and ", so that you could do:
>>
>> Yes, I understood your suggestion as such. Quoting like shells would work
>> without breaking backward compatibility for the same reason quoting with
>> double-quote and backslash only without supporting single-quotes would
>> work.
>
> Having said that, "It would work" does not have to mean "Hence we
> must do it that way" at all. Quoting character pairs make the
> parsing and unquoting significantly more complex.
>
> As you said, not many people used attributes and pathspec magic, and
> I do not think those who want to use the new "further limits with
> attributes" magic, envisioned primarily to be those who want to give
> classes to submodules, have compelling reason to name their classes
> with anything but lowercase-ascii-alphabet tokens. So for a practical
> purposes, I'd rather see Stefan
>
> * just implement backquote-blindly-passes-the-next-byte and nothing
> more elaborate; and
>
> * forbid [^-a-z0-9,_] from being used in the value part in the
> attr:VAR=VAL magic.
>
> at least for now, and concentrate more on the other more important
> parts of the submodule enhancement topic.
OK, that reasonable. I didn't mean to derail Stefan's development!
ATB,
Ramsay Jones
>
> That way, those who will start using attr:VAR=VAL magic will stick
> themselves to lowercase-ascii-alphabet tokens for now (simply
> because an attribut that has the forbidden characters in its value
> would not be usable with the magic), and we can later extend the
> magic syntax parser in a backward compatible way to allow paired
> quotes and other "more convenient" syntax.
>
>
> [Footnote]
>
> *1* The reason I prefer to keep the initially allowed value
> characters narrow is because I envision that something like
>
> :(attr:VAR=(<some expression we will come up with later>))
>
> may become necessary, and do not want to promise users that open or
> close parentheses will forever be taken literally.
>
>
next prev parent reply other threads:[~2016-06-02 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 23:52 [RFC/PATCH] pathspec: allow escaped query values Stefan Beller
2016-06-02 0:33 ` Junio C Hamano
2016-06-02 2:23 ` Stefan Beller
2016-06-02 0:38 ` Ramsay Jones
2016-06-02 2:20 ` Stefan Beller
2016-06-02 5:46 ` Junio C Hamano
2016-06-02 15:30 ` Ramsay Jones
2016-06-02 16:10 ` Junio C Hamano
2016-06-02 18:42 ` Ramsay Jones
2016-06-02 18:58 ` Junio C Hamano
2016-06-02 19:29 ` Junio C Hamano
2016-06-02 19:52 ` Ramsay Jones [this message]
2016-06-02 19:04 ` Stefan Beller
2016-06-02 19:44 ` Ramsay Jones
2016-06-02 19:46 ` Junio C Hamano
2016-06-02 19:53 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57508E75.8050501@ramsayjones.plus.com \
--to=ramsay@ramsayjones$(echo .)plus.com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox