Subject: Re: [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform

From: Michael Haggerty <[email-masked]>
Date: Mon, 13 Jun 2016 09:16:05 +0200

On 06/10/2016 09:01 PM, David Turner wrote:
> On Fri, 2016-06-10 at 10:14 +0200, Michael Haggerty wrote:
> 
>>  /*
>> + * Check whether the REF_HAVE_OLD and old_oid values stored in update
>> + * are consistent with the result read for the reference. error is
>> + * true iff there was an error reading the reference; otherwise, oid
> 
> "error" is not a thing here?

You're right; thanks for the feedback. I'll include it in the reroll
that I'm about to do.

Michael