Subject: RE: [PATCH 2/3] Makefile: stop hardcoding {command,config}-list.h

From: Felipe Contreras <[email-masked]>
Date: Thu, 17 Jun 2021 15:14:09 -0500

Ævar Arnfjörð Bjarmason wrote:
> Change various places that hardcode the names of these two files to
> refer to either $(GENERATED_H), or to a new generated-hdrs
> target.

Avoiding hard-coded things is generally a good idea, and I can smell
there's an advantage nearby, but it's not stated.

Can you spell out what you are trying to achieve?

> Hardcoding command-list.h there seems to have been a case of
> copy/paste programming in dce7d29551 (msvc: support building Git using
> MS Visual C++, 2019-06-25).

Actually that's not the commit, it's this one:

976aaedca0 (msvc: add a Makefile target to pre-generate the Visual
Studio solution, 2019-07-29)

The changes themselves look good to me.

-- 
Felipe Contreras