Subject: Re: [PATCH v3 11/34] fsmonitor-fs-listen-win32: stub in backend for Windows

From: Felipe Contreras <[email-masked]>
Date: Fri, 16 Jul 2021 11:59:57 -0500

Johannes Schindelin wrote:
> On Fri, 2 Jul 2021, Ævar Arnfjörð Bjarmason wrote:
> > On Thu, Jul 01 2021, Jeff Hostetler via GitGitGadget wrote:

> > > @@ -2793,6 +2803,9 @@ GIT-BUILD-OPTIONS: FORCE
> > >  	@echo PAGER_ENV=\''$(subst ','\'',$(subst ','\'',$(PAGER_ENV)))'\' >>$@+
> > >  	@echo DC_SHA1=\''$(subst ','\'',$(subst ','\'',$(DC_SHA1)))'\' >>$@+
> > >  	@echo X=\'$(X)\' >>$@+
> > > +ifdef FSMONITOR_DAEMON_BACKEND
> > > +	@echo FSMONITOR_DAEMON_BACKEND=\''$(subst ','\'',$(subst ','\'',$(FSMONITOR_DAEMON_BACKEND)))'\' >>$@+
> > > +endif
> >
> > Why put this in an ifdef?
> 
> Why not? What benefit does this question bring to improving this patch
> series?

This is a common debate tactic known as "shifting the burden of proof".

Ævar does not need to prove that your patch is undesirable, *you* have
to prove that it is desirable.

You have the burden of proof, so you should answer the question.

https://www.logicallyfallacious.com/logicalfallacies/Shifting-of-the-Burden-of-Proof

-- 
Felipe Contreras