From: "Windl, Ulrich" <u.windl@ukr•de>
To: Junio C Hamano <gitster@pobox•com>
Cc: "René Scharfe" <l.s.r@web•de>,
"git@vger•kernel.org" <git@vger•kernel.org>,
"Phillip Wood" <phillip.wood@dunelm•org.uk>
Subject: RE: [EXT] Re: [PATCH v2 1/5] add-patch: improve help for options j, J, k, and K
Date: Mon, 3 Nov 2025 12:43:10 +0000 [thread overview]
Message-ID: <61fcb89b5843474693ea6d6c90609180@ukr.de> (raw)
In-Reply-To: <xmqqjz0axj1i.fsf@gitster.g>
OK,
fair enough: I think the original wording is more clear, so I don't see the need to change it at all.
Possible corner cases ecepted, e.g. whether "next" can wrap at the end or not.
Kind regards,
Ulrich Windl
> -----Original Message-----
> From: Junio C Hamano <gitster@pobox•com>
> Sent: Saturday, November 1, 2025 9:19 AM
> To: Windl, Ulrich <u.windl@ukr•de>
> Cc: René Scharfe <l.s.r@web•de>; git@vger•kernel.org; Phillip Wood
> <phillip.wood@dunelm•org.uk>
> Subject: [EXT] Re: [PATCH v2 1/5] add-patch: improve help for options j, J, k,
> and K
>
> Sicherheits-Hinweis: Diese E-Mail wurde von einer Person außerhalb des UKR
> gesendet. Seien Sie vorsichtig vor gefälschten Absendern, wenn Sie auf Links
> klicken, Anhänge öffnen oder weitere Aktionen ausführen, bevor Sie die
> Echtheit überprüft haben.
>
> "Windl, Ulrich" <u.windl@ukr•de> writes:
>
> > For the patch
> > diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> > index ad629c46c5..3266ccf105 100644
> >
> > I don't see an actual improvement, and I'd prefer the previous
> > version of the doc.
>
> We'd prefer to see something more concrete that refuses the
> reasoning that led to the change, than a subjective "I don't see,
> I'd prefer".
>
> At least, the commit log messge given by 2c3cc43f (add-patch:
> improve help for options j, J, k, and K, 2025-10-06) explains why
> the change is an improvement, and I found it sensible.
> (<b5034851-65bd-49da-b270-48b68d9210ff@web•de>)
>
> The old description said 'j' leaves this hunk undecided and goes to
> the next undecided hunk, but it is both pointless and misleading to
> say 'leave this hunk undecided'. Unlike 'y' or 'n', the movement
> options 'j', 'k' are not about changing the state of the current
> thing we are on (so it is pointless to say "LEAVE it undecided"),
> and more importantly, when we say 'j', the state of the current
> thing we are on may not necessarily be 'undecided' (so it is
> misleading to say "leave it UNDECIDED").
next prev parent reply other threads:[~2025-11-03 12:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 9:23 Broken handling of "J" hunks for "add --interactive"? Windl, Ulrich
2025-10-03 12:16 ` [PATCH] add-patch: roll over to next undecided hunk René Scharfe
2025-10-03 13:41 ` Phillip Wood
2025-10-03 14:10 ` René Scharfe
2025-10-08 13:47 ` Phillip Wood
2025-10-03 16:11 ` Junio C Hamano
2025-10-03 19:53 ` René Scharfe
2025-10-03 20:39 ` Junio C Hamano
2025-10-03 20:42 ` Junio C Hamano
2025-10-03 21:18 ` Junio C Hamano
2025-10-05 15:45 ` [PATCH v2 0/5] " René Scharfe
2025-10-05 15:55 ` [PATCH v2 1/5] add-patch: improve help for options j, J, k, and K René Scharfe
2025-10-05 21:30 ` Junio C Hamano
2025-10-06 17:17 ` René Scharfe
2025-10-06 17:58 ` Junio C Hamano
2025-10-31 10:08 ` [EXT] " Windl, Ulrich
2025-11-01 8:18 ` Junio C Hamano
2025-11-03 12:43 ` Windl, Ulrich [this message]
2025-10-05 15:55 ` [PATCH v2 2/5] add-patch: document that option J rolls over René Scharfe
2025-10-05 21:30 ` Junio C Hamano
2025-10-05 15:55 ` [PATCH v2 3/5] add-patch: let options y, n, j, and e roll over to next undecided René Scharfe
2025-10-05 15:55 ` [PATCH v2 4/5] add-patch: let options k and K roll over like j and J René Scharfe
2025-10-05 20:55 ` Junio C Hamano
2025-10-06 17:18 ` René Scharfe
2025-10-05 15:55 ` [PATCH v2 5/5] add-patch: reset "permitted" at loop start René Scharfe
2025-10-06 17:18 ` [PATCH v3 0/6] add-patch: roll over to next undecided hunk René Scharfe
2025-10-06 17:19 ` [PATCH v3 1/6] add-patch: improve help for options j, J, k, and K René Scharfe
2025-10-06 17:20 ` [PATCH v3 2/6] add-patch: document that option J rolls over René Scharfe
2025-10-06 17:21 ` [PATCH v3 3/6] add-patch: let options y, n, j, and e roll over to next undecided René Scharfe
2025-10-06 17:22 ` [PATCH v3 4/6] add-patch: let options k and K roll over like j and J René Scharfe
2025-10-06 17:23 ` [PATCH v3 5/6] add-patch: let options a and d roll over like y and n René Scharfe
2025-10-06 17:24 ` [PATCH v3 6/6] add-patch: reset "permitted" at loop start René Scharfe
2025-10-31 10:28 ` [EXT] " Windl, Ulrich
2025-10-31 15:16 ` Junio C Hamano
2025-10-06 18:00 ` [PATCH v3 0/6] add-patch: roll over to next undecided hunk Junio C Hamano
2025-10-06 20:05 ` René Scharfe
2025-10-06 22:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61fcb89b5843474693ea6d6c90609180@ukr.de \
--to=u.windl@ukr$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=l.s.r@web$(echo .)de \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox