From: Felipe Contreras <felipe.contreras@gmail•com>
To: Jeff King <peff@peff•net>, Felipe Contreras <felipe.contreras@gmail•com>
Cc: git@vger•kernel.org, "Junio C Hamano" <gitster@pobox•com>,
"Martin Ågren" <martin.agren@gmail•com>
Subject: Re: [PATCH] doc: remove custom callouts format
Date: Tue, 18 Apr 2023 01:25:13 -0600 [thread overview]
Message-ID: <643e45d9222ae_21b04329432@chronos.notmuch> (raw)
In-Reply-To: <20230418044142.GA130759@coredump.intra.peff.net>
Jeff King wrote:
> On Tue, Apr 18, 2023 at 12:00:34AM -0400, Jeff King wrote:
>
> > It's probably still worth moving forward with your patch, as I think it
> > takes us in the direction we want long-term (and which builds with
> > asciidoctor are already using). But we may want to pair it with a patch
> > to work around the issue with git-checkout.1 using asciidoc to avoid
> > regressing that section. It may require re-wording or re-organizing to
> > work around the bug.
>
> Just to clarify my comment on asciidoctor: since our Makefile will put
> its output through docbook, too, it actually is using the xsl you're
> removing here (though I'm unclear on why its output looks good in
> general even before your patch).
It's probably a quirk of the git hack for callouts, but that's specific to
manpages.
Have you looked at the HTML output generated by asciidoc-py? The badly indented
output suggests this issue has nothing to do with my patch.
--
Felipe Contreras
next prev parent reply other threads:[~2023-04-18 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 1:18 [PATCH] doc: remove custom callouts format Felipe Contreras
2023-04-18 4:00 ` Jeff King
2023-04-18 4:41 ` Jeff King
2023-04-18 7:25 ` Felipe Contreras [this message]
2023-04-18 5:30 ` Felipe Contreras
2023-04-18 6:17 ` Jeff King
2023-04-18 7:15 ` Felipe Contreras
2023-04-18 9:03 ` Jeff King
2023-04-18 9:50 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643e45d9222ae_21b04329432@chronos.notmuch \
--to=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=martin.agren@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox