public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Arti Zirk <arti.zirk@gmail•com>
To: Alecs King <alecsk@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] instaweb: fix ip binding for the python http.server
Date: Wed, 15 Jan 2025 11:24:46 +0200	[thread overview]
Message-ID: <6deb9ea67b2dafb12d02146a29a35ddd970f7c06.camel@gmail.com> (raw)
In-Reply-To: <20250110101346.30416-1-alecsk@gmail.com>

On R, 2025-01-10 at 18:13 +0800, Alecs King wrote:
> `git instaweb -d python` should bind the server to 0.0.0.0
> `git instaweb -d python -l` should bind the server to 127.0.0.1

Thanks for noticing that bug and sending a patch!


>  GitWebRequestHandler(CGIHTTPRequestHandler):

NB: Looks like CGI support will be removed some time in the future and
the Python backend for instaweb will stop working afterwards.

https://docs.python.org/3.13/library/http.server.html#http.server.CGIHTTPRequestHandler

When I get the time I should look into cleaning up the instaweb script.

      parent reply	other threads:[~2025-01-15  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 10:13 [PATCH] instaweb: fix ip binding for the python http.server Alecs King
2025-01-10 23:32 ` Junio C Hamano
2025-01-15  9:24 ` Arti Zirk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6deb9ea67b2dafb12d02146a29a35ddd970f7c06.camel@gmail.com \
    --to=arti.zirk@gmail$(echo .)com \
    --cc=alecsk@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox