Subject: Re: [PATCH v8 0/4] Introduce libgit-rs, a Rust wrapper around libgit.a

From: Phillip Wood <[email-masked]>
Date: Wed, 29 Jan 2025 15:24:05 +0000

Hi Josh

On 28/01/2025 22:01, Josh Steadmon wrote:

Thanks for re-rolling, the range-diff looks good to me apart from

>       +void libgit_configset_free(struct libgit_config_set *cs)
>       +{
>      -+	git_configset_clear((struct config_set *) cs);
>      -+	free((struct config_set *) cs);
>      ++	git_configset_clear(&cs->cs);
>      ++	free(&cs->cs);

Which I think should be "free(cs)". In practice it does not matter 
because we pass the same value to free() but it seems a bit odd to pass 
the address of the first member of the struct rather than the address of 
the struct itself.

I'm looking forward to seeing this merged soon

Best Wishes

Phillip