From: Johannes Schindelin <Johannes.Schindelin@gmx•de>
To: Scott Chacon via GitGitGadget <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Scott Chacon <schacon@gmail•com>,
Scott Chacon <schacon@gmail•com>
Subject: Re: [PATCH] help: interpret help.autocorrect=1 as "immediate" rather than 0.1s
Date: Thu, 9 Jan 2025 01:18:15 +0100 (CET) [thread overview]
Message-ID: <7553dc2b-7b91-31c9-e86e-aa24d3bb4235@gmx.de> (raw)
In-Reply-To: <pull.1869.git.git.1736364707068.gitgitgadget@gmail.com>
Hi Scott,
On Wed, 8 Jan 2025, Scott Chacon via GitGitGadget wrote:
> From: Scott Chacon <schacon@gmail•com>
>
> Many people confusingly set the "help.autocorrect" setting to 1 believing it
> to be a boolean that turns on the autocorrect feature rather than an integer
> value of deciseconds wait time. Since it's impossible for a human being to
> react this quickly, the help message stating that it's waiting for 0.1s
> before continuing becomes confusingly comical.
>
> This patch simply interprets a "1" value as the same as the "immedate"
> autocorrect setting, which makes it skip the 0.1s and simply say that it's
> running the command, which is almost certainly what everyone setting it to
> that value is actually trying to do.
Not trying to brag but I had no problems understanding this commit
message as-is.
> Signed-off-by: Scott Chacon <schacon@gmail•com>
> ---
> help: interpret help.autocorrect=1 as "immediate" rather than 0.1s
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1869%2Fschacon%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1869/schacon/master-v1
> Pull-Request: https://github.com/git/git/pull/1869
>
> help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/help.c b/help.c
> index 5483ea8fd29..e6576644b99 100644
> --- a/help.c
> +++ b/help.c
> @@ -568,7 +568,7 @@ static int git_unknown_cmd_config(const char *var, const char *value,
> return config_error_nonbool(var);
> if (!strcmp(value, "never")) {
> cfg->autocorrect = AUTOCORRECT_NEVER;
> - } else if (!strcmp(value, "immediate")) {
> + } else if (!strcmp(value, "immediate") || !strcmp(value, "1")) {
Makes sense to me!
For the record, I do think it was a mistake to treat number values as
"deciseconds" here, it is inconsistent with pretty much any other config
setting. But I also don't see any way to remediate this design mistake at
this stage.
Thank you for working on this and making the feature at least a little bit
more usable.
Ciao,
Johannes
> cfg->autocorrect = AUTOCORRECT_IMMEDIATELY;
> } else if (!strcmp(value, "prompt")) {
> cfg->autocorrect = AUTOCORRECT_PROMPT;
>
> base-commit: 14650065b76b28d3cfa9453356ac5669b19e706e
> --
> gitgitgadget
>
>
next prev parent reply other threads:[~2025-01-09 0:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 19:31 [PATCH] help: interpret help.autocorrect=1 as "immediate" rather than 0.1s Scott Chacon via GitGitGadget
2025-01-08 21:42 ` Kristoffer Haugsbakk
2025-01-09 0:18 ` Johannes Schindelin [this message]
2025-01-13 23:33 ` Taylor Blau
2025-01-09 1:12 ` Junio C Hamano
2025-01-09 7:05 ` Yongmin
2025-01-09 10:49 ` [PATCH v2] help: interpret boolean string values for help.autocorrect Scott Chacon via GitGitGadget
2025-01-09 16:32 ` Junio C Hamano
2025-01-10 7:43 ` Scott Chacon
2025-01-10 9:30 ` Scott Chacon
2025-01-10 12:11 ` Jeff King
2025-01-10 15:02 ` Junio C Hamano
2025-01-11 11:27 ` [PATCH v3] " Scott Chacon via GitGitGadget
2025-01-13 5:43 ` Jeff King
2025-01-13 9:31 ` Scott Chacon
2025-01-13 16:18 ` Junio C Hamano
2025-01-18 1:12 ` Junio C Hamano
2025-01-13 9:33 ` [PATCH v4] " Scott Chacon via GitGitGadget
2025-02-01 21:33 ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false David Aguilar
2025-02-01 21:33 ` [PATCH 2/2] help: add "show" as a valid configuration value David Aguilar
2025-02-03 22:53 ` Junio C Hamano
2025-02-03 22:53 ` [PATCH 1/2] help: show the suggested command when help.autocorrect is false Junio C Hamano
2025-02-04 3:05 ` Jeff King
2025-02-04 13:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7553dc2b-7b91-31c9-e86e-aa24d3bb4235@gmx.de \
--to=johannes.schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=schacon@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox