public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Derrick Stolee <stolee@gmail•com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail•com>,
	git@vger•kernel.org
Cc: Toon Claes <toon@iotcl•com>,
	Johannes Schindelin <johannes.schindelin@gmx•de>
Subject: Re: [PATCH] last-modified: support sparse checkouts
Date: Sun, 30 Nov 2025 15:00:30 -0500	[thread overview]
Message-ID: <75f862a5-2663-4211-b96c-d2c5d1c6f91e@gmail.com> (raw)
In-Reply-To: <pull.2013.git.1764423826908.gitgitgadget@gmail.com>

On 11/29/2025 8:43 AM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx•de>
> 
> In a sparse checkout, a user might want to run `last-modified` on a
> directory outside the worktree.
> 
> And even in non-sparse checkouts, a user might need to run that command
> on a directory that does not exist in the worktree.
> 
> These use cases should be supported via the `--` separator between
> revision and file arguments, which is even advertised in the
> documentation. This patch fixes a tiny bug that prevents that from
> working.

>  	argc = parse_options(argc, argv, prefix, last_modified_options,
>  			     last_modified_usage,
> -			     PARSE_OPT_KEEP_ARGV0 | PARSE_OPT_KEEP_UNKNOWN_OPT);
> +			     PARSE_OPT_KEEP_ARGV0 | PARSE_OPT_KEEP_UNKNOWN_OPT |
> +			     PARSE_OPT_KEEP_DASHDASH);

I'm intrigued that this is the only fix that was required.

> +test_expect_success 'last-modified in sparse checkout' '
> +	test_when_finished "git sparse-checkout disable" &&
> +	git sparse-checkout set b &&
> +	check_last_modified -- a <<-\EOF

Would we expect this to work without the '--'? Should it
fail for a directory that exists at HEAD but is outside of
the sparse-checkout?

Thanks,
-Stolee

next prev parent reply	other threads:[~2025-11-30 20:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29 13:43 [PATCH] last-modified: support sparse checkouts Johannes Schindelin via GitGitGadget
2025-11-30 20:00 ` Derrick Stolee [this message]
2025-12-03 11:11   ` Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75f862a5-2663-4211-b96c-d2c5d1c6f91e@gmail.com \
    --to=stolee@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitgitgadget@gmail$(echo .)com \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=toon@iotcl$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox