From: Luben Tuikov <ltuikov@yahoo•com>
To: Jakub Narebski <jnareb@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH (amend)] gitweb: Slight visual improvements to commitdiff view
Date: Thu, 26 Oct 2006 17:39:14 -0700 (PDT) [thread overview]
Message-ID: <780488.44315.qm@web31803.mail.mud.yahoo.com> (raw)
In-Reply-To: <200610270150.40100.jnareb@gmail.com>
--- Jakub Narebski <jnareb@gmail•com> wrote:
> First, I have removed creating empty divs. The div with number of
> changed files in git_difftree_body is added only if the message about
> number of changed files is displayed (above 10).
>
> Second, I have moved commit message body in commitdiff outside
> "page_body" div, to be together with "author_date" div with authorship
> info. The name of class was changed from "log" to more informative
> "commitdiff_log". This required some changes and additions to CSS. Now
> "commitdiff_log" div is responsible for displaying line separatring it
> from "page_body".
>
> I have added not full line above "patchset" div (between patchet and
> difftree). It is added by "patchset" div and separated by 8px padding.
>
>
> Those changes might wait for proper refactoring of gitweb CSS (having
> for example 8px padding in one place only).
Excellent! I'd like this explanation to be part of the
commit message if that patchset is committed to git.git.
Luben
next prev parent reply other threads:[~2006-10-27 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 16:13 [PATCH] gitweb: Slight visual improvements to commitdiff view Jakub Narebski
2006-10-26 16:43 ` [PATCH (amend)] " Jakub Narebski
2006-10-26 23:34 ` Luben Tuikov
2006-10-26 23:50 ` Jakub Narebski
2006-10-27 0:39 ` Luben Tuikov [this message]
2006-10-27 1:42 ` Junio C Hamano
2006-10-27 1:47 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=780488.44315.qm@web31803.mail.mud.yahoo.com \
--to=ltuikov@yahoo$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox