From: Phillip Wood <phillip.wood123@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Bello Caleb Olamide <belkid98@gmail•com>,
git@vger•kernel.org, toon@iotcl•com, christian.couder@gmail•com,
usmanakinyemi202@gmail•com, kaartic.sivaraam@gmail•com,
me@ttaylorr•com, karthik.188@gmail•com,
phillip.wood@dunelm•org.uk
Subject: Re: [Outreachy PATCH v6 1/3] environment: stop storing `core.attributesFile` globally
Date: Thu, 12 Feb 2026 10:33:33 +0000 [thread overview]
Message-ID: <7d9e0e9b-4565-492c-81b7-2471a916015e@gmail.com> (raw)
In-Reply-To: <xmqq5x83w7m1.fsf@gitster.g>
On 11/02/2026 16:46, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail•com> writes:
>
> At the beginning of repo_config_values() in the patch, there is a
> check to ensure that repo->initialized is true and otherwise you get
> an error. But the initialization is already done in the early part
> of initialize_repository() as quoted above. So I do not see what
> difference it would make if we rewrote the last line as
In Bello's patch there is a second assertion in repo_config_values()
that checks "repo == the_repository" and that one fails. I suggested
adding it because the config values are still global rather than per
repository so we should only be reading them from "the_repository".
Thanks
Phillip
> repo_config_values_init(&repo->config_values_private_);
>
> I am confused.
>
next prev parent reply other threads:[~2026-02-12 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 10:17 [Outreachy PATCH v6 1/3] environment: stop storing `core.attributesFile` globally Bello Caleb Olamide
2026-02-10 15:07 ` Phillip Wood
2026-02-11 8:05 ` Bello Olamide
2026-02-11 9:31 ` Phillip Wood
2026-02-11 12:05 ` Bello Olamide
2026-02-11 16:46 ` Junio C Hamano
2026-02-12 10:33 ` Phillip Wood [this message]
2026-02-12 17:13 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2026-02-03 15:42 [Outreachy PATCH v6 0/3] store repo specific config values in new `struct repo_config_values` Olamide Caleb Bello
2026-02-03 15:42 ` [Outreachy PATCH v6 1/3] environment: stop storing `core.attributesFile` globally Olamide Caleb Bello
2026-02-04 16:39 ` Phillip Wood
2026-02-09 8:47 ` Bello Olamide
2026-02-07 1:14 ` Junio C Hamano
2026-02-08 11:14 ` Phillip Wood
2026-02-09 8:54 ` Bello Olamide
2026-02-10 8:40 ` Bello Olamide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9e0e9b-4565-492c-81b7-2471a916015e@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=belkid98@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kaartic.sivaraam@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=toon@iotcl$(echo .)com \
--cc=usmanakinyemi202@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox