Subject: Re: [PATCH] Make git-clean a builtin

From: Junio C Hamano <[email-masked]>
Date: Mon, 05 Nov 2007 15:54:18 -0800

"Carlos Rica" <[email-masked]> writes:

> 2007/11/5, Junio C Hamano <[email-masked]>:
>> Shawn Bohrer <[email-masked]> writes:
>>
>> > +static int show_only = 0;
>> > +static int remove_directories = 0;
>> > +static int quiet = 0;
>> > +static int ignored = 0;
>> > +static int ignored_only = 0;
>>
>> Please do not explicitly initialize static variables to zero.
>
> Is it really needed to declare those variables outside of a function
> in this case?

I do not think so --- I suspect that this is a simple cut &
paste from the standalone ls-files implementation.