From: Junio C Hamano <junkio@cox•net>
To: Andy Parkins <andyparkins@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/RFC] Have git-cvsserver call hooks/update before really altering the ref
Date: Tue, 13 Feb 2007 21:36:28 -0800 [thread overview]
Message-ID: <7v4pppuwpv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200702131512.45412.andyparkins@gmail.com> (Andy Parkins's message of "Tue, 13 Feb 2007 15:12:45 +0000")
Andy Parkins <andyparkins@gmail•com> writes:
> diff --git a/git-cvsserver.perl b/git-cvsserver.perl
> index 9371788..b4ef6bc 100755
> --- a/git-cvsserver.perl
> +++ b/git-cvsserver.perl
> @@ -1171,6 +1171,21 @@ sub req_ci
> exit;
> }
>
> + # Check that this is allowed, just as we would with a receive-pack
> + my @cmd = ( $ENV{GIT_DIR}.'hooks/update', "refs/heads/$state->{module}",
> + $parenthash, $commithash );
> + if( -x $cmd[0] ) {
> + unless( system( @cmd ) == 0 )
> + {
> + $log->warn("Commit failed (update hook declined to update ref)");
> + print "error 2 Commit failed (update hook declined)\n";
Everybody else seems to say 'print "error 1 blah blah"'. Are
you sure "error 2 message" is Kosher protocol-wise?
next prev parent reply other threads:[~2007-02-14 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 15:12 [PATCH/RFC] Have git-cvsserver call hooks/update before really altering the ref Andy Parkins
2007-02-13 17:43 ` Junio C Hamano
2007-02-13 17:54 ` Nicolas Pitre
2007-02-13 18:07 ` Junio C Hamano
2007-02-13 18:14 ` Andy Parkins
2007-02-14 5:36 ` Junio C Hamano [this message]
2007-02-14 9:13 ` Andy Parkins
2007-02-14 9:33 ` Junio C Hamano
2007-02-19 20:59 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4pppuwpv.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=andyparkins@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox