From: Junio C Hamano <gitster@pobox•com>
To: Jakub Narebski <jnareb@gmail•com>
Cc: Michael J Gruber <git@drmicha•warpmail.net>,
Git Mailing List <git@vger•kernel.org>,
Cord Seele <cowose@gmail•com>, Cord Seele <cowose@googlemail•com>
Subject: Re: [PATCH] send-email: Fix %config_path_settings handling
Date: Fri, 14 Oct 2011 16:23:50 -0700 [thread overview]
Message-ID: <7v62jrxim1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 201110142253.32695.jnareb@gmail.com
Jakub Narebski <jnareb@gmail•com> writes:
> From: Cord Seele <cowose@gmail•com>
> ...
> Signed-off-by: Cord Seele <cowose@gmail•com>
> Tested-by: Michael J Gruber <git@drmicha•warpmail.net>
> Signed-off-by: Jakub Narebski <jnareb@gmail•com>
Thanks.
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 579ddb7..87b4acc 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -1168,4 +1168,32 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' '
> test -n "$(ls msgtxt*)"
> '
>
> +test_expect_success $PREREQ 'sendemail.aliasfiletype=mailrc' '
> + clean_fake_sendmail &&
> + echo "alias sbd somebody@example•org" >.mailrc &&
> + git config --replace-all sendemail.aliasesfile "$(pwd)/.mailrc" &&
> + git config sendemail.aliasfiletype mailrc &&
> + git send-email \
> + --from="Example <nobody@example•com>" \
> + --to=sbd \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + outdir/0001-*.patch \
> + 2>errors >out &&
> + grep "^!somebody@example\.org!$" commandline1
> +'
> +
> +test_expect_success $PREREQ 'sendemail.aliasfile=~/.mailrc' '
> + clean_fake_sendmail &&
> + echo "alias sbd someone@example•org" >~/.mailrc &&
> + git config --replace-all sendemail.aliasesfile "~/.mailrc" &&
> + git config sendemail.aliasfiletype mailrc &&
> + git send-email \
> + --from="Example <nobody@example•com>" \
> + --to=sbd \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + outdir/0001-*.patch \
> + 2>errors >out &&
> + grep "^!someone@example\.org!$" commandline1
> +'
> +
> test_done
prev parent reply other threads:[~2011-10-14 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 12:29 [BUG] send-email: alias expansion broken Michael J Gruber
2011-10-14 14:25 ` [PATCH] fix alias expansion with new Git::config_path() Cord Seele
2011-10-14 14:30 ` Michael J Gruber
2011-10-14 14:42 ` Cord Seele
2011-10-14 15:05 ` Junio C Hamano
2011-10-14 16:38 ` Jakub Narebski
2011-10-14 18:13 ` Junio C Hamano
2011-10-14 18:49 ` [PATCH] send-email: Fix %config_path_settings handling Jakub Narebski
2011-10-14 19:26 ` Junio C Hamano
2011-10-14 20:53 ` Jakub Narebski
2011-10-14 23:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v62jrxim1.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=cowose@gmail$(echo .)com \
--cc=cowose@googlemail$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox