Subject: Re: [PATCH] git-send-email.perl: Really add angle brackets to In-Reply-To if necessary

From: Junio C Hamano <[email-masked]>
Date: Sun, 09 Dec 2007 10:09:44 -0800

Mike Hommey <[email-masked]> writes:

> 3803bcea tried to fix this, but it only adds the branckes when the given
> In-Reply-To begins and ends with whitespaces. It also didn't do anything
> to the --in-reply-to argument.
>
> Signed-off-by: Mike Hommey <[email-masked]>
> ---
>
> I just got bitten by this...

Interesting.

>
>  git-send-email.perl |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 76baa8e..1434eb2 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -367,10 +367,11 @@ if ($thread && !defined $initial_reply_to && $prompting) {
>  	} while (!defined $_);
>  
>  	$initial_reply_to = $_;
> -	$initial_reply_to =~ s/^\s+<?/</;
> -	$initial_reply_to =~ s/>?\s+$/>/;
>  }

I wonder what the original rationale for these \s+ was.
Will apply, anyway.  Thanks.

>  
> +$initial_reply_to =~ s/^\s*\<?/\</;
> +$initial_reply_to =~ s/>?\s*$/>/;
> +
>  if (!defined $smtp_server) {
>  	foreach (qw( /usr/sbin/sendmail /usr/lib/sendmail )) {
>  		if (-x $_) {
> -- 
> 1.5.3.7