From: Junio C Hamano <gitster@pobox•com>
To: John Keeping <john@keeping•me.uk>
Cc: git@vger•kernel.org, "Eric S. Raymond" <esr@thyrsus•com>,
Chris Rorvick <chris@rorvick•com>
Subject: Re: [PATCH] git-cvsimport.txt: cvsps-2 is deprecated
Date: Thu, 24 Jan 2013 12:04:11 -0800 [thread overview]
Message-ID: <7v7gn2bb5w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130124191845.GS7498@serenity.lan> (John Keeping's message of "Thu, 24 Jan 2013 19:18:45 +0000")
John Keeping <john@keeping•me.uk> writes:
> git-cvsimport relies on version 2 of cvsps and does not work with the
> new version 3. Since cvsps 3.x does not currently work as well as
> version 2 for incremental import, document this fact.
>
> Specifically, there is no way to make new git-cvsimport that supports
> cvsps 3.x and have a seamless transition for existing users since cvsps
> 3.x needs a time from which to continue importing and git-cvsimport does
> not save the time of the last import or import into a specific namespace
> so there is no safe way to calculate the time of the last import.
Isn't the whole "and git-cvsimport does not save the time..." part
something that can be fixed in the new cvsimport that reads the
output from cvsps3?
To me, it sounds more like
cvsps2 + cvsimport has an unfixable bugs and there have been an
effort to rewrite cvsps2 from scratch. The resulting cvsp3
currently is unusable with cvsimport, especially when importing
the history incrementally, and it isn't expected that it will
ever be usable with cvsimport again.
There are other tools that analyse the original history better
and emits more correct output when used to convert the whole
history, and hopefully cvsps3 + fast-import would become one of
them. Suggest users to use them instead of cvsimport when they
are not doing an incremental import.
By the way, do we want to make any recommendation to the distro
folks which cvsps they should ship? It appears that not shipping
cvsps2 would be a major regression if cvsps3 does not plan to
support incrementals, so shipping both might be the safest way for
them to support their users with different needs.
Thanks. I think the patch text itself is good.
> Signed-off-by: John Keeping <john@keeping•me.uk>
> ---
> On Wed, Jan 23, 2013 at 09:04:12PM -0800, Junio C Hamano wrote:
>> Care to roll a proper patch with a log message? I'll discard the
>> topic for now and replace it with your documentation update.
>
> Here it is.
>
> Documentation/git-cvsimport.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/git-cvsimport.txt b/Documentation/git-cvsimport.txt
> index 9d5353e..f059ea9 100644
> --- a/Documentation/git-cvsimport.txt
> +++ b/Documentation/git-cvsimport.txt
> @@ -18,6 +18,12 @@ SYNOPSIS
>
> DESCRIPTION
> -----------
> +*WARNING:* `git cvsimport` uses cvsps version 2, which is considered
> +deprecated; it does not work with cvsps version 3 and later. If you are
> +performing a one-shot import of a CVS repository consider using
> +link:http://cvs2svn.tigris.org/cvs2git.html[cvs2git] or
> +link:https://github.com/BartMassey/parsecvs[parsecvs].
> +
> Imports a CVS repository into git. It will either create a new
> repository, or incrementally import into an existing one.
next prev parent reply other threads:[~2013-01-24 20:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 22:44 What's cooking in git.git (Jan 2013, #08; Tue, 22) Junio C Hamano
2013-01-22 23:45 ` John Keeping
2013-01-23 0:11 ` Junio C Hamano
2013-01-23 9:28 ` John Keeping
2013-01-23 13:26 ` Chris Rorvick
2013-01-23 13:55 ` John Keeping
2013-01-23 17:13 ` Junio C Hamano
2013-01-23 21:12 ` John Keeping
2013-01-24 5:04 ` Junio C Hamano
2013-01-24 19:18 ` [PATCH] git-cvsimport.txt: cvsps-2 is deprecated John Keeping
2013-01-24 20:04 ` Junio C Hamano [this message]
2013-01-24 20:13 ` John Keeping
2013-01-24 20:58 ` Junio C Hamano
2013-01-25 4:55 ` What's cooking in git.git (Jan 2013, #08; Tue, 22) Chris Rorvick
2013-01-25 9:09 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7gn2bb5w.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=chris@rorvick$(echo .)com \
--cc=esr@thyrsus$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox