From: Junio C Hamano <gitster@pobox•com>
To: Paul Mackerras <paulus@samba•org>,
Alexandre Erwin Ittner <alexandre@ittner•com.br>
Cc: git@vger•kernel.org
Subject: Re: Please pull gitk.git master branch
Date: Sun, 12 Dec 2010 19:11:57 -0800 [thread overview]
Message-ID: <7v7hfe74ea.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vwrne8tow.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun\, 12 Dec 2010 15\:20\:15 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Thanks, pulled (not yet pushed out).
Yikes.
Paul, has this ever been install-tested before you accepted the "pt-BR"
patch to your repository?
"msgfmt --tcl" produces po/pt_br.msg for me, but the Makefile wants to
install po/pt_BR.msg and fails. Perhaps the poor-man's po2msg.sh does not
have this glitch and produces po/pt_BR.msg, but I don't think that is an
excuse for not checking with both that script and the real msgfmt before
the change gets this far.
Using the -o option on the msgfmt command line to force the command to
generate pt_BR.msg fails with:
msgfmt: --tcl and --output-file are mutually exclusive
Combined with this and the fact that msgfmt produces po/pt_br.msg out of
the input po/pt_BR.po makes me suspect that Tcl runtime enviornment does
not actually expect pt_BR.msg but want to see the country part downcased.
In which case we may need to fix po2msg.sh to match that behaviour.
An workaround would be to rename po/pt_BR.po to po/pt_br.po but I don't
know if there are unexpected side effects if we did that.
I'd like to see this glitch sorted out before I push out the result of the
merge, so it is likely there won't be a pushout tonight. We need to know:
* Is this "downcase the country part for --tcl" a bug in the particular
version of msgfmt I happen to have (it is 0.17 from GNU gettext on
Debian), or is it the filename convention expected by the Tcl i18n
runtime environment to have both language and country in lowercase?
* What is the recommended best practice in Tcl i18n community for naming
lang_COUNTRY.po file? Do people typically spell the COUNTRY in
uppercase and let "msgfmt --tcl" downcase, and deal with the filename
case issues in the Makefile themselves? This feels yucky, as it means
that we cannot use '%.msg : %.po' dependency pattern, but need to list
the dependencies by hand. Or do they spell country part in lowercase
to avoid this whole issue?
My _preferred_ outcome is to see that naming the input "po/pt_br.po" and
using the output "po/pt_br.msg" is the BCP, but I'd like somebody to find
out what the accepted practice would be in the Tcl land first.
next prev parent reply other threads:[~2010-12-13 3:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 6:31 Please pull gitk.git master branch Paul Mackerras
2010-12-12 23:20 ` Junio C Hamano
2010-12-13 3:11 ` Junio C Hamano [this message]
2010-12-13 7:40 ` Junio C Hamano
2010-12-13 8:36 ` Sverre Rabbelier
2010-12-13 9:25 ` Andreas Ericsson
2010-12-13 19:52 ` Andreas Schwab
2010-12-13 21:03 ` Paul Mackerras
2010-12-13 21:45 ` Junio C Hamano
2010-12-14 9:07 ` Paul Mackerras
2010-12-14 17:09 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2010-01-29 11:59 Paul Mackerras
2010-01-29 20:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7hfe74ea.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=alexandre@ittner$(echo .)com.br \
--cc=git@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox