Subject: Re: [PATCH] Fix branches file configuration

From: Junio C Hamano <[email-masked]>
Date: Wed, 26 Mar 2008 01:03:01 -0700

From: Daniel Barkalow <[email-masked]>
Date: Tue, 25 Mar 2008 19:35:28 -0400
Subject: [PATCH] Fix branches file configuration

Fetched remote branch from .git/branches/foo should fetch into
refs/heads/foo.  Also when partial URL is given, the fetched head should
always be remote HEAD, and the result should not be stored anywhere.

Signed-off-by: Daniel Barkalow <[email-masked]>
Signed-off-by: Junio C Hamano <[email-masked]>
---

 Junio C Hamano <[email-masked]> writes:

 > Daniel Barkalow <[email-masked]> writes:
 >
 >> ... (See line 115 of 755225de:git-parse-remote.sh)
 >
 > Yeah, sounds like it.  Will queue in 'next', for eventual inclusion in
 > 'maint'.  This is a 1.5.4 regression fix, together with "push --tags" fix
 > we discussed today.

 Actually there seems to be one more difference.  Here is what I think is
 needed for 'maint'.

 remote.c |   28 ++++++++++++++++++++++------
 1 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/remote.c b/remote.c
index 95d65a0..d8a4671 100644
--- a/remote.c
+++ b/remote.c
@@ -171,7 +171,7 @@ static void read_branches_file(struct remote *remote)
 {
 	const char *slash = strchr(remote->name, '/');
 	char *frag;
-	char *branch;
+	struct strbuf branch;
 	int n = slash ? slash - remote->name : 1000;
 	FILE *f = fopen(git_path("branches/%.*s", n, remote->name), "r");
 	char *s, *p;
@@ -197,17 +197,33 @@ static void read_branches_file(struct remote *remote)
 	strcpy(p, s);
 	if (slash)
 		strcat(p, slash);
+
+	/*
+	 * With "slash", e.g. "git fetch jgarzik/netdev-2.6" when
+	 * reading from $GIT_DIR/branches/jgarzik fetches "HEAD" from
+	 * the partial URL obtained from the branches file plus
+	 * "/netdev-2.6" and does not store it in any tracking ref.
+	 * #branch specifier in the file is ignored.
+	 *
+	 * Otherwise, the branches file would have URL and optionally
+	 * #branch specified.  The "master" (or specified) branch is
+	 * fetched and stored in the local branch of the same name.
+	 */
+	strbuf_init(&branch, 0);
 	frag = strchr(p, '#');
 	if (frag) {
 		*(frag++) = '\0';
-		branch = xmalloc(strlen(frag) + 12);
-		strcpy(branch, "refs/heads/");
-		strcat(branch, frag);
+		strbuf_addf(&branch, "refs/heads/%s", frag);
+	} else
+		strbuf_addstr(&branch, "refs/heads/master");
+	if (!slash) {
+		strbuf_addf(&branch, ":refs/heads/%s", remote->name);
 	} else {
-		branch = "refs/heads/master";
+		strbuf_reset(&branch);
+		strbuf_addstr(&branch, "HEAD:");
 	}
 	add_url(remote, p);
-	add_fetch_refspec(remote, branch);
+	add_fetch_refspec(remote, strbuf_detach(&branch, 0));
 	remote->fetch_tags = 1; /* always auto-follow */
 }
 
-- 
1.5.5.rc1.128.g340c