Subject: Re: [PATCH 3/4] Move the file read logic to read_patch_file() in builtin-apply.c

From: Junio C Hamano <[email-masked]>
Date: Sun, 09 Dec 2007 10:27:01 -0800

Mike Hommey <[email-masked]> writes:

> This will allow to extend the read logic further. We also return a better
> error message than usage() when the given filename can't be opened, and
> avoid whitespace options not being set when reading from stdin with the
> "-" argument as a side effect.

I think this is a good clean-up, but I suspect that apply_patch() should
be further refactored to take strbuf, instead of <fd, filename>
(original) or <filename> (yours).