From: Junio C Hamano <gitster@pobox•com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail•com>
Cc: git@vger•kernel.org, tbushnell@google•com, tytso@google•com
Subject: Re: What's cooking in git.git (Jan 2012, #08; Tue, 31)
Date: Thu, 09 Feb 2012 21:48:44 -0800 [thread overview]
Message-ID: <7v8vkbs0g3.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8B_nsZnSarbRaBoxviK1xa_PVP0-DbnMiP9HkwzrztfJg@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Fri, 10 Feb 2012 11:43:23 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail•com> writes:
> No objections. Does it fix a failed test? If not, should we add a test
> to record this side effect fix?
No, it was just "I tried this and it did not work" reported elsewhere, and
it is not v1.7.9 regression. Having seen a failure by a real user, having
a test would be a good idea to protect the fix from regressing.
I actually wish that the commit 9e58504 (clone: --branch=<branch> always
means refs/heads/<branch>, 2012-01-16) wasn't taken hostage to the earlier
changes that add new feature (addition of --single-branch and delaying of
the cloning before checking the remote HEAD); which would have been an
easier sell without violating the usual "no new features to maintenance
track". And the thing is, I do not find this grave enough an issue that
deserves a separate implementation of a fix to be queued to maintenance
tracks.
> --mirror implies --bare in cmd_clone() if I read it correctly.
Yeah, what was I thinking... feeling stupid.
Thanks.
prev parent reply other threads:[~2012-02-10 5:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 7:19 What's cooking in git.git (Jan 2012, #08; Tue, 31) Junio C Hamano
2012-02-01 12:07 ` Jakub Narebski
2012-02-01 20:37 ` Junio C Hamano
2012-02-01 20:46 ` Junio C Hamano
2012-02-02 4:21 ` Junio C Hamano
2012-02-10 2:27 ` Junio C Hamano
2012-02-10 4:09 ` Junio C Hamano
2012-02-10 4:43 ` Nguyen Thai Ngoc Duy
2012-02-10 5:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vkbs0g3.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=tbushnell@google$(echo .)com \
--cc=tytso@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox