From: Junio C Hamano <gitster@pobox•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Clemens Buchacher <drizzd@aon•at>, git@vger•kernel.org
Subject: Re: [PATCH 1/3] remove prefix argument from pathspec_prefix
Date: Tue, 06 Sep 2011 12:58:16 -0700 [thread overview]
Message-ID: <7vaaah8muf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vmxeh8pf4.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 06 Sep 2011 12:02:39 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Is it because we no longer ever return "prefix" we pass in which is a
> pointer to a constant memory region to begin with?
>
> We also didn't free() in the earlier code (because we do not know if it
> can be freed) and leaking xmemdupz() if the function didn't return the
> "prefix", but now you plugged the small leak. Isn't it something you
> should advertise?
Nah, the leak is not necessarily plugged in all callers anyway, so scratch
that part. I've rewritten it like this:
commit 5879f5684cfe8a38326b4ffd078f96e35c68e640
Author: Clemens Buchacher <drizzd@aon•at>
Date: Sun Sep 4 12:41:59 2011 +0200
remove prefix argument from pathspec_prefix
Passing a prefix to a function that is supposed to find the prefix is
strange. And it's really only used if the pathspec is NULL. Make the
callers handle this case instead.
As we are always returning a fresh copy of a string (or NULL), change the
type of the returned value to non-const "char *".
Signed-off-by: Clemens Buchacher <drizzd@aon•at>
Signed-off-by: Junio C Hamano <gitster@pobox•com>
next prev parent reply other threads:[~2011-09-06 19:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-23 20:25 Possible bug Reuben Thomas
2011-07-25 7:42 ` [RFC/PATCH] commit: allow partial commits with relative paths Michael J Gruber
2011-07-25 19:02 ` Junio C Hamano
2011-07-25 19:32 ` Junio C Hamano
2011-07-27 8:22 ` Michael J Gruber
2011-07-27 9:45 ` Reuben Thomas
2011-07-27 9:53 ` Michael J Gruber
2011-07-27 10:00 ` Reuben Thomas
2011-07-27 10:19 ` John Szakmeister
2011-07-27 11:56 ` [RFC/PATCH] ls-files: fix pathspec display on error Michael J Gruber
2011-07-29 13:03 ` Clemens Buchacher
2011-08-01 0:01 ` Junio C Hamano
2011-08-01 18:03 ` [PATCH] test ls-files with relative paths Clemens Buchacher
2011-08-01 20:14 ` Junio C Hamano
2011-08-01 21:19 ` [PATCH v2] ls-files: fix pathspec display on error Clemens Buchacher
2011-08-01 22:30 ` Junio C Hamano
2011-07-28 7:38 ` [RFC/PATCH] commit: allow partial commits with relative paths Erik Faye-Lund
2011-07-27 15:37 ` Junio C Hamano
2011-07-27 15:41 ` Junio C Hamano
2011-07-27 15:50 ` Michael J Gruber
2011-07-29 13:35 ` [PATCH] " Clemens Buchacher
2011-07-30 16:45 ` Michael J Gruber
2011-07-30 17:00 ` Clemens Buchacher
2011-07-30 17:04 ` Michael J Gruber
2011-07-30 17:13 ` [PATCH v2] " Clemens Buchacher
2011-08-01 0:05 ` Junio C Hamano
2011-08-02 21:31 ` Junio C Hamano
2011-08-03 19:28 ` Clemens Buchacher
2011-08-03 22:07 ` Junio C Hamano
2011-09-04 10:41 ` renaming pathspec_prefix (was: Re: [PATCH v2] commit: allow partial commits with relative paths) Clemens Buchacher
2011-09-04 10:41 ` [PATCH 1/3] remove prefix argument from pathspec_prefix Clemens Buchacher
2011-09-06 19:02 ` Junio C Hamano
2011-09-06 19:58 ` Junio C Hamano [this message]
2011-09-08 7:12 ` Clemens Buchacher
2011-09-08 16:51 ` Junio C Hamano
2011-09-04 10:42 ` [PATCH 2/3] consolidate pathspec_prefix and common_prefix Clemens Buchacher
2011-09-04 10:42 ` [PATCH 3/3] rename pathspec_prefix -> common_prefix and move to dir.[ch] Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaaah8muf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=drizzd@aon$(echo .)at \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox