From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Ralf Thielow <ralf.thielow@googlemail•com>,
git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] commit: Remove backward goto in read_craft_line()
Date: Wed, 01 Dec 2010 12:19:59 -0800 [thread overview]
Message-ID: <7vaakputxs.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20101201194441.GB27347@burratino> (Jonathan Nieder's message of "Wed\, 1 Dec 2010 13\:44\:42 -0600")
Jonathan Nieder <jrnieder@gmail•com> writes:
>> @@ -155,6 +151,11 @@ struct commit_graft *read_graft_line(char *buf, int len)
>> goto bad_graft_data;
>> }
>> return graft;
>> +
>> +bad_graft_data:
>> + error("bad graft data: %s", buf);
>
> A space before the "bad_graft_data:" label would improve future
> diff --show-c-function output.
Hmm, I actually do not think we encourage that (nor we should).
$ git grep -e '^ [a-z0-9]*:' -- '*.c' | wc -l
23
$ git grep -e '^[a-z0-9]*:' -- '*.c' | wc -l
42
If "--show-c-function" output is the problem, perhaps we should know a bit
better about what C function header looks like?
next prev parent reply other threads:[~2010-12-01 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 19:15 [PATCH] commit: Remove backward goto in read_craft_line() Ralf Thielow
2010-12-01 19:44 ` Jonathan Nieder
2010-12-01 20:19 ` Junio C Hamano [this message]
2010-12-01 20:31 ` Jonathan Nieder
2010-12-01 20:44 ` Ralf Thielow
2010-12-01 21:07 ` Trivial patches (Re: [PATCH] commit: Remove backward goto in read_craft_line()) Jonathan Nieder
2010-12-01 21:19 ` [PATCH] commit: Remove backward goto in read_craft_line() Junio C Hamano
2010-12-01 21:40 ` Ralf Thielow
-- strict thread matches above, loose matches on Subject: below --
2010-12-01 19:59 Ralf Thielow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vaakputxs.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=ralf.thielow@googlemail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox