public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Johan Herland <johan@herland•net>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire•com>, git@vger•kernel.org
Subject: Re: [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIR
Date: Tue, 12 Feb 2008 23:58:23 -0800	[thread overview]
Message-ID: <7vabm5s2xs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200802130411.22093.johan@herland.net> (Johan Herland's message of "Wed, 13 Feb 2008 04:11:22 +0100")

Johan Herland <johan@herland•net> writes:

> The testcase verifies that 'git cvsexportcommit' functions correctly when
> the '-w' option is used, and GIT_DIR is set to a relative path (e.g. '.').
>
> Signed-off-by: Johan Herland <johan@herland•net>
> ---
>
> On Tuesday 12 February 2008, Robin Rosenberg wrote:
>> Looks ok. Something for the test suite?
>
> Like this?

Yeah, looks good.

Except that I'll reorder the patches so that

 (1) this test comes first, but with test_expect_failure instead;

 (2) then your earlier fix patch, but with a change that changes
     the test_expect_failure to test_expect_success.

Thanks.

Perhaps it would be a good idea to require fix-up patches to
always come with a test case to prevent future regression.

next prev parent reply	other threads:[~2008-02-13  7:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  1:28 [PATCH] Fix 'git cvsexportcommit -w $cvsdir ...' when used with relative $GIT_DIR Johan Herland
2008-02-11 20:10 ` Junio C Hamano
2008-02-11 20:58 ` Robin Rosenberg
2008-02-11 23:43   ` Johan Herland
2008-02-12 20:41     ` Robin Rosenberg
2008-02-13  3:11       ` [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' " Johan Herland
2008-02-13  7:58         ` Junio C Hamano [this message]
2008-02-13  9:26           ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vabm5s2xs.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johan@herland$(echo .)net \
    --cc=robin.rosenberg.lists@dewire$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox