Subject: Re: [PATCH] Remove duplication in t9119-git-svn-info.sh

From: Junio C Hamano <[email-masked]>
Date: Tue, 01 Jan 2008 21:57:09 -0800

Eric Wong <[email-masked]> writes:

> Junio C Hamano <[email-masked]> wrote:
>> "David D. Kilzer" <[email-masked]> writes:
>> 
>> > @@ -350,8 +355,8 @@ test_expect_success 'info unknown-symlink-directory' "
>> >  	cd svnwc &&
>> >  		ln -s unknown-directory unknown-symlink-directory &&
>> >  	cd .. &&
>> > -	ptouch gitwc/unknown-symlink-directory \
>> > -	       svnwc/unknown-symlink-directory &&
>> > +	ptouch svnwc/unknown-symlink-directory \
>> > +	       gitwc/unknown-symlink-directory &&
>> 
>> Hmph.  Am I the only one who finds this repetition somewhat
>> disturbing?
>
> "David D. Kilzer" <[email-masked]> wrote:
>> Simplify arguments to ptouch bash function.
>
> Not reading Junio's mind, I think he meant that you were swapping the
> "gitwc/" and "svnwc/" args everywhere in your changeset.

Yeah, that was what I meant.  ptouch routine's implementation
could have swapped the order of arguments internally.

The follow-up patch by David makes ptouch routine unusable if
the test suite becomes more elaborate and starts using more than
one git and svn work trees, but I do not think that is something
we have to worry about too much.