From: Junio C Hamano <gitster@pobox•com>
To: Marc Strapetz <marc.strapetz@syntevo•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: Possible timestamp problems with diff-files?
Date: Wed, 21 Sep 2011 14:33:02 -0700 [thread overview]
Message-ID: <7vboud1sz5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4E79DF81.8090605@syntevo.com> (Marc Strapetz's message of "Wed, 21 Sep 2011 14:58:41 +0200")
Marc Strapetz <marc.strapetz@syntevo•com> writes:
> On 20.09.2011 19:54, Jeff King wrote:
>> On Tue, Sep 20, 2011 at 12:30:53PM +0200, Marc Strapetz wrote:
>>
>>> For our Git client, we are invoking
>>>
>>> git diff-files--quiet --ignore-submodules
>>>
>>> immediately after a commit of *all* changes. Hence, the expected exit
>>> code would be 0 (because there are no changes). A user has now reported
>>> that for commits with many changes, exit code is sometimes 1. For the
>>> last incident, the commit was started at 15:24:11,820 and finished at
>>> 15:24:12,329, diff-files was invoked at 15:24:12,455 and failed with
>>> exit code 1 at 15:24:21,394. A subsequent diff-files succeeded, so I'm
>>> wondering now, if that could be a timestamp problem (maybe related to
>>> the Index)?
What peff said already.
If you do not refresh the cached stat information, diff-files may report
"they differ" for a path that is otherwise unchanged without looking at
the contents of such a path to notice that the only difference is the
cached stat information (the whole and only point of having the cached
stat information is to avoid looking at the contents). Also, it may look
at the contents of such a path if it has a reason to suspect that the file
might have changed if it cannot tell from the cached stat information
(look for "racy-git" if you are really interested).
Update the cached stat information before you use plumbing commands in
your script.
next prev parent reply other threads:[~2011-09-21 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:30 Possible timestamp problems with diff-files? Marc Strapetz
2011-09-20 17:54 ` Jeff King
2011-09-21 12:58 ` Marc Strapetz
2011-09-21 21:33 ` Junio C Hamano [this message]
2011-09-24 14:30 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vboud1sz5.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=marc.strapetz@syntevo$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox