public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: David Aguilar <davvid@gmail•com>
Cc: git@vger•kernel.org, gitster@pobox•com, peff@peff•net,
	markus.heidelberg@web•de, jnareb@gmail•com, j.sixt@viscovery•net
Subject: Re: [PATCH v6 2/3] compat: add a basename() compatibility function
Date: Sat, 30 May 2009 21:53:06 -0700	[thread overview]
Message-ID: <7vbpp9vpot.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20090531044246.GA23995@gmail.com> (David Aguilar's message of "Sat\, 30 May 2009 21\:42\:47 -0700")

David Aguilar <davvid@gmail•com> writes:

>> +#ifdef USE_WIN32_FS
>> +	/* Skip over the disk name in MSDOS pathnames. */
>> +	if (isalpha(path[0]) && path[1] == ':')
>> +		path += 2;
>> +#endif
>
> Thanks for bearing through this series everyone.. ;)
>
> Can someone with better win32 knowledge let me know if the
> USE_WIN32_FS stuff is needed for msysgit?
>
> I would really like it if there was a way to do without the
> #define.

Isn't this essentially the same as has_dos_drive_prefix()?

  reply	other threads:[~2009-05-31  4:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-31  4:37 [PATCH v6 1/3] compat: add a mkstemps() compatibility function David Aguilar
2009-05-31  4:37 ` [PATCH v6 2/3] compat: add a basename() " David Aguilar
2009-05-31  4:37   ` [PATCH v6 3/3] diff: generate pretty filenames in prep_temp_blob() David Aguilar
2009-05-31  4:42   ` [PATCH v6 2/3] compat: add a basename() compatibility function David Aguilar
2009-05-31  4:53     ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-31  8:11 j.sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbpp9vpot.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=davvid@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j.sixt@viscovery$(echo .)net \
    --cc=jnareb@gmail$(echo .)com \
    --cc=markus.heidelberg@web$(echo .)de \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox