From: Junio C Hamano <gitster@pobox•com>
To: Pierre Habouzit <madcoder@debian•org>
Cc: Yann Dirson <ydirson@altern•org>, git@vger•kernel.org
Subject: Re: [PATCH] parse-opt: bring PARSE_OPT_HIDDEN to git-rev-parse --parseopt
Date: Sun, 24 Feb 2008 00:42:26 -0800 [thread overview]
Message-ID: <7vbq66ycct.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080223140926.GD10967@artemis.madism.org> (Pierre Habouzit's message of "Sat, 23 Feb 2008 15:09:26 +0100")
Pierre Habouzit <madcoder@debian•org> writes:
> I also made the parsing more extensible wrt new flags if needed.
>
> We should definitely write tests too.
> ...
> + case '*':
> + o->flags &= PARSE_OPT_HIDDEN;
> + break;
I have a slight suspicion that this is not what you meant.
You probably meant either |= or perhaps ^=.
next prev parent reply other threads:[~2008-02-24 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 23:01 [PATCH] Improve documentation for git-sh-setup Yann Dirson
2008-02-22 9:35 ` Pierre Habouzit
2008-02-22 17:17 ` Junio C Hamano
2008-02-22 18:19 ` Pierre Habouzit
2008-02-23 14:09 ` [PATCH] parse-opt: bring PARSE_OPT_HIDDEN to git-rev-parse --parseopt Pierre Habouzit
2008-02-24 8:42 ` Junio C Hamano [this message]
2008-02-24 8:49 ` Pierre Habouzit
-- strict thread matches above, loose matches on Subject: below --
2008-03-02 8:21 Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq66ycct.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=madcoder@debian$(echo .)org \
--cc=ydirson@altern$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox