From: Junio C Hamano <gitster@pobox•com>
To: "Shawn O. Pearce" <spearce@spearce•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/7] Use 'printf %s $x' notation in t5401
Date: Wed, 30 Jan 2008 17:16:59 -0800 [thread overview]
Message-ID: <7vbq72hjzo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080130064845.GR24004@spearce.org> (Shawn O. Pearce's message of "Wed, 30 Jan 2008 01:48:45 -0500")
"Shawn O. Pearce" <spearce@spearce•org> writes:
> Junio C Hamano <gitster@pobox•com> wrote:
>> ...
>> Do you really mean this? "printf %s 1 2 3" writes "123" without
>> terminating LF. You seem to check only for size but to be
>> reusable you might want to use something like:
>
> The only thing we care about is was there args or not to the hook.
> I probably could do that test differently, like say:
>
> echo $# >$GIT_DIR/pre-receive.args
>
> and then test that the file contains "0" instead of looking for it to
> be empty. Not sure why I didn't write it that way in the beginning.
>
>> printf '%s\n' "$@"
>
> Eh. Since all we care is that the argument count is 0 we probably
> should be looking at $# and calling it a day.
I'll apply as-is, but once you break the code that calls
pre-receive hook in such a way that it sends unexpected
arguments, you'd thank me for suggesting to print the arguments
separately while debugging the problem with the test script.
next prev parent reply other threads:[~2008-01-31 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 6:21 [PATCH 1/7] Use 'printf %s $x' notation in t5401 Shawn O. Pearce
2008-01-30 6:40 ` Junio C Hamano
2008-01-30 6:48 ` Shawn O. Pearce
2008-01-31 1:16 ` Junio C Hamano [this message]
2008-01-31 3:41 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbq72hjzo.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox