From: Junio C Hamano <junkio@cox•net>
To: Simon Arlott <simon@arlott•org>
Cc: git@vger•kernel.org
Subject: Re: git.kernel.org disconnects when git-1.3.3 tries to pull changes
Date: Mon, 23 Oct 2006 18:23:34 -0700 [thread overview]
Message-ID: <7vbqo2wlpl.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <453D583E.3010601@simon.arlott.org.uk> (Simon Arlott's message of "Tue, 24 Oct 2006 01:03:10 +0100")
Yes, this is a recent breakage. Thanks for bringing it up.
We need at least a fix like this in 'maint'.
diff --git a/daemon.c b/daemon.c
index ad84928..e66bb80 100644
--- a/daemon.c
+++ b/daemon.c
@@ -450,6 +450,8 @@ void fill_in_extra_table_entries(struct
* Replace literal host with lowercase-ized hostname.
*/
hp = interp_table[INTERP_SLOT_HOST].value;
+ if (!hp)
+ return;
for ( ; *hp; hp++)
*hp = tolower(*hp);
@@ -544,8 +546,10 @@ #endif
loginfo("Extended attributes (%d bytes) exist <%.*s>",
(int) pktlen - len,
(int) pktlen - len, line + len + 1);
- if (len && line[len-1] == '\n')
+ if (len && line[len-1] == '\n') {
line[--len] = 0;
+ pktlen--;
+ }
/*
* Initialize the path interpolation table for this connection.
next prev parent reply other threads:[~2006-10-24 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 0:03 git.kernel.org disconnects when git-1.3.3 tries to pull changes Simon Arlott
2006-10-24 1:23 ` Junio C Hamano [this message]
2006-10-30 19:53 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbqo2wlpl.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=simon@arlott$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox