From: Junio C Hamano <gitster@pobox•com>
To: Marcus Comstedt <marcus@mc•pp.se>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 1/2] convert: fix normalization of foreign idents
Date: Sun, 12 Sep 2010 14:44:59 -0700 [thread overview]
Message-ID: <7vd3sid4bo.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <yf9hbhuisla.fsf@chiyo.mc.pp.se> (Marcus Comstedt's message of "Sun\, 12 Sep 2010 23\:01\:53 +0200")
Marcus Comstedt <marcus@mc•pp.se> writes:
>> It also smells wrong that this "sometimes we convert, sometimes we don't"
>> is a special case for "$Id$" and for no other conversion. Why don't
>> smudge/clean filter or CRLF conversion have the same issue that can be
>> solved with the same approach as this patch takes?
>
> I gather that this is because nobody has come up with a use case
> for smudge/clean or CRLF where a (pervasive) non-normalized
> representation in the repository makes sense.
Think a bit more about what you just wrote means.
Imagine there isn't any "$Id$" (or "$ident$" as it was originally known)
expansion in git. You can implement it easily using a smudge/clean pair,
and the smudge and clean should be conditionally applied in the codepath
you touched using exactly the same logic as your patch uses, no?
That is what I meant. It smells wrong to make this "sometime we do,
sometimes we don't" as a special case for "$Id$". Specifically, the
parameter name "normalize_foreign_ident" feels wrong; the concept that the
parameter tries to convey covers much wider than just "foreign ident", no?
next prev parent reply other threads:[~2010-09-12 21:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 21:30 Fix for normalization of foreign idents Marcus Comstedt
2010-08-23 21:30 ` [PATCH] convert: fix " Marcus Comstedt
2010-08-23 21:35 ` Fix for " Jonathan Nieder
2010-08-23 21:44 ` Marcus Comstedt
2010-08-23 22:33 ` Jonathan Nieder
2010-08-23 23:46 ` Junio C Hamano
2010-08-24 7:23 ` Marcus Comstedt
2010-09-06 9:42 ` Marcus Comstedt
2010-09-06 21:07 ` Jonathan Nieder
2010-09-07 19:37 ` Marcus Comstedt
2010-08-23 7:05 ` [PATCH v2 1/2] convert: fix " Marcus Comstedt
2010-09-10 0:26 ` Junio C Hamano
2010-09-12 21:01 ` Marcus Comstedt
2010-09-12 21:44 ` Junio C Hamano [this message]
2010-09-12 22:06 ` Marcus Comstedt
2010-09-13 22:00 ` [PATCH] convert: generalize checksafe parameter Marcus Comstedt
2010-09-07 19:16 ` [PATCH v2 2/2] t0021: test checkout and commit of foreign idents Marcus Comstedt
2010-09-07 20:00 ` [PATCH v2 0/2] fix normalization of foreign idents (now with test cases) Marcus Comstedt
2010-09-08 4:32 ` Fix for normalization of foreign idents Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd3sid4bo.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=marcus@mc$(echo .)pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox