From: Junio C Hamano <junkio@cox•net>
To: Andreas Ericsson <ae@op5•se>
Cc: git@vger•kernel.org, Jakub Narebski <jnareb@gmail•com>
Subject: Re: [PATCH] Documentation: Update information about <format> in git-for-each-ref
Date: Wed, 01 Nov 2006 00:47:34 -0800 [thread overview]
Message-ID: <7vd5877duh.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <45485A0F.3040807@op5.se> (Andreas Ericsson's message of "Wed, 01 Nov 2006 09:25:51 +0100")
Andreas Ericsson <ae@op5•se> writes:
> Jakub Narebski wrote:
>
>> BTW. I had to translate
>> + if (strcmp(who, "tagger") && strcmp(who, "committer"))
>> to
>> + if (strcmp(who, "tagger") == 0 || strcmp(who, "committer") == 0)
>> to understand it. But this is probably my lack of contact with such
>> C idioms.
>
> But this does the exact opposite....
> "Compare" (as in "strcmp") also translates to "are equal to" and isn't
> only a verb. This is unfortunate for people who aren't natively
> english and has had me confused on many a long night...
Being a non-English speaker, I always pronounce xxxcmp() used as
boolean 'is different' in my head. The (correct version of the)
above example expression is read as 'if it is different from
"tagger" and it is different from "committer", then do this'.
Otherwise I pronounce xxxcmp(a,b) "difference"; it's sign
matches (a-b).
if (xxxcmp(a,b) < 0) is similar to if ((a-b) < 0) which is
equivalent to if (a < b).
next prev parent reply other threads:[~2006-11-01 8:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 17:30 [PATCH] Documentation: Update information about <format> in git-for-each-ref Jakub Narebski
2006-10-28 20:33 ` Junio C Hamano
2006-10-28 21:23 ` Jakub Narebski
2006-11-01 8:25 ` Andreas Ericsson
2006-11-01 8:47 ` Junio C Hamano [this message]
2006-11-01 10:23 ` Andreas Ericsson
2006-11-01 15:30 ` Junio C Hamano
2006-11-01 15:48 ` Johannes Schindelin
2006-11-02 19:17 ` [PATCH 1/2] for-each-ref: "creator" and "creatordate" fields Jakub Narebski
2006-11-02 19:23 ` [PATCH 2/2] gitweb: Use git-for-each-ref to generate list of heads and/or tags Jakub Narebski
2006-11-03 2:40 ` Junio C Hamano
2006-11-03 3:26 ` Jakub Narebski
2006-11-03 2:40 ` [PATCH 1/2] for-each-ref: "creator" and "creatordate" fields Junio C Hamano
2006-11-03 3:27 ` Jakub Narebski
2006-10-28 20:42 ` [PATCH] Documentation: Update information about <format> in git-for-each-ref Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd5877duh.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=ae@op5$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox