From: Junio C Hamano <junkio@cox•net>
To: Petr Baudis <pasky@suse•cz>, Morten Welinder <mwelinder@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Fix errno usage in connect.c
Date: Sat, 01 Jul 2006 17:09:48 -0700 [thread overview]
Message-ID: <7vd5codfzn.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060701215626.GB29115@pasky.or.cz> (Petr Baudis's message of "Sat, 1 Jul 2006 23:56:26 +0200")
Petr Baudis <pasky@suse•cz> writes:
> Dear diary, on Wed, Jun 28, 2006 at 06:56:12PM CEST, I got a letter
> where Morten Welinder <mwelinder@gmail•com> said that...
>> It looks like connect.c waits too long before it uses errno in both copies
>> of git_tcp_connect_sock. Both close and freeaddrinfo can poke any
>> non-zero value in there.
>
> Nice catch.
>
> ->8-
>
> errno was used after it could've been modified by a subsequent library call.
> Spotted by Morten Welinder.
>
> Signed-off-by: Petr Baudis <pasky@suse•cz>
Thanks.
prev parent reply other threads:[~2006-07-02 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 16:56 connect.c and errno Morten Welinder
2006-07-01 21:56 ` [PATCH] Fix errno usage in connect.c Petr Baudis
2006-07-02 0:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd5codfzn.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=mwelinder@gmail$(echo .)com \
--cc=pasky@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox