From: Junio C Hamano <junkio@cox•net>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Shallow clone: low level machinery.
Date: Tue, 31 Jan 2006 09:49:53 -0800 [thread overview]
Message-ID: <7vd5i81e4e.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0601311449040.8033@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Tue, 31 Jan 2006 14:58:21 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
> apart from my thinking this is not backward-compatible (you are supposed
> to be able to pull from a complete repo, even if it has a
> non-shallow-capable upload-pack), here are my comments:
It cannot do a shallow clone against older servers, no. I think
it should be able to do a full clone from older servers, but I
need to double check -- at least that is how I meant to write
that thing but it was late night ;-).
> - it is good that MAXPARENT and struct commit_graft are in more public
> places now.
>
> - reparse_* is misleading. Nothing is reparsed, but rather "unparsed".
I meant to reparse them thear but forgot. Will remember to fix.
> - I'd hesitate to let git-daemon write temporary files. That is a whole
> new can of security worms.
>
> - The custom_graft issue could be handled in a more elegant manner if
> git was lib'ified (no temporary file). Since that is already the
> plan, why not do that first, and come back later?
That is why it does not write any temporary files. It
introduces a way to read graft information from an environment
variable.
> - It looks wrong to me to define MAX_PARENTS as 20 in upload-pack.c, when
> MAXPARENT is defined as 16 in cache.h.
This is remnant from my earlier one that did not move MAXPARENT
out from commit-tree I forgot to clean up before calling it a
day. Will remember to clean up.
next prev parent reply other threads:[~2006-01-31 17:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 7:18 [RFC] shallow clone Junio C Hamano
2006-01-30 11:39 ` Johannes Schindelin
2006-01-30 11:58 ` Simon Richter
2006-01-30 12:13 ` Johannes Schindelin
2006-01-30 13:25 ` Simon Richter
2006-01-30 19:25 ` Junio C Hamano
2006-01-31 11:28 ` Johannes Schindelin
2006-01-31 13:05 ` Simon Richter
2006-01-31 13:31 ` Johannes Schindelin
2006-01-31 14:23 ` Simon Richter
2006-01-30 19:25 ` Junio C Hamano
2006-01-31 8:37 ` Franck
2006-01-31 8:51 ` Junio C Hamano
2006-01-31 11:11 ` Franck
2006-01-30 18:46 ` Junio C Hamano
2006-01-31 11:02 ` [PATCH] Shallow clone: low level machinery Junio C Hamano
2006-01-31 13:58 ` Johannes Schindelin
2006-01-31 17:49 ` Junio C Hamano [this message]
2006-01-31 18:06 ` Johannes Schindelin
2006-01-31 18:22 ` Junio C Hamano
2006-02-01 14:33 ` Johannes Schindelin
2006-02-01 20:27 ` Junio C Hamano
2006-02-02 0:48 ` Johannes Schindelin
2006-02-02 1:17 ` Junio C Hamano
2006-02-02 18:44 ` Johannes Schindelin
2006-02-02 19:31 ` Junio C Hamano
2006-01-31 14:20 ` [RFC] shallow clone Johannes Schindelin
2006-01-31 20:59 ` Junio C Hamano
2006-02-01 14:47 ` Johannes Schindelin
[not found] ` <43DF1F1D.1060704@innova-card.com>
2006-01-31 9:00 ` Franck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vd5i81e4e.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox