Subject: Re: [PATCH 3/3] pretty=format: Avoid some expensive calculations when not needed

From: Junio C Hamano <[email-masked]>
Date: Mon, 05 Nov 2007 17:06:25 -0800

René Scharfe <[email-masked]> writes:

> Junio C Hamano schrieb:
> ...
>> Instead of allocating a separate array and freeing at the end,
>> wouldn't it make more sense to have a bitfield that records what
>> is used by the format string inside the array elements?
>
> How about (ab)using the value field?  Let interp_find_active() mark
> unneeded entries with NULL, and the rest with some cookie.  All table
> entries with non-NULL values need to be initialized.  interp_set_entry()
> needs to be aware of this cookie, as it mustn't free() it.  The cookie
> could be the address of a static char* in interpolate.c.

Sorry, where is this aversion to making the struct a bit larger
coming from?