From: Junio C Hamano <gitster@pobox•com>
To: Johannes Sixt <j.sixt@viscovery•net>
Cc: mhagger@alum•mit.edu, git@vger•kernel.org,
Jeff King <peff@peff•net>, Drew Northup <drew.northup@maine•edu>,
Jakub Narebski <jnareb@gmail•com>,
Heiko Voigt <hvoigt@hvoigt•net>,
Johan Herland <johan@herland•net>,
Julian Phillips <julian@quantumfyre•co.uk>
Subject: Re: [PATCH] t1402-check-ref-format: skip tests of refs beginning with slash on Windows
Date: Thu, 13 Oct 2011 16:00:04 -0700 [thread overview]
Message-ID: <7vfwiw33bf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4E969BFC.50706@viscovery.net> (Johannes Sixt's message of "Thu, 13 Oct 2011 10:06:20 +0200")
Johannes Sixt <j.sixt@viscovery•net> writes:
> This patch is needed on top of mh/check-ref-format-3, or it could be
> inserted in front of this batch (which probably amounts to the same
> thing :-)
How about applying directly on 'master' then?
> +invalid_ref NOT_MINGW '/'
> ...
> @@ -155,21 +155,21 @@ test_expect_success 'check-ref-format --branch from subdir' '
> '
>
> valid_ref_normalized() {
> - test_expect_success "ref name '$1' simplifies to '$2'" "
> + test_expect_success $3 "ref name '$1' simplifies to '$2'" "
> refname=\$(git check-ref-format --normalize '$1') &&
> test \"\$refname\" = '$2'"
> }
> invalid_ref_normalized() {
> - test_expect_success "check-ref-format --normalize rejects '$1'" "
> + test_expect_success $2 "check-ref-format --normalize rejects '$1'" "
> test_must_fail git check-ref-format --normalize '$1'"
> }
> ...
> +valid_ref_normalized '/heads/foo' 'heads/foo' NOT_MINGW
The inconsistencies strikes me a bit.
Perhaps update to something like this?
valid_ref_normalized () {
if test $# = 3
then
prereq=$1
shift
fi
test_expect_success $prereq "ref name '$1' simplifies to '$2'"
...
}
next prev parent reply other threads:[~2011-10-13 23:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 7:58 [PATCH 00/14] Tidying up references code mhagger
2011-10-13 7:58 ` [PATCH 01/14] cache.h: add comments for git_path() and git_path_submodule() mhagger
2011-10-13 18:37 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 02/14] struct ref_list: document name member mhagger
2011-10-13 18:37 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 03/14] refs.c: rename some local "refname" variables mhagger
2011-10-13 7:58 ` [PATCH 04/14] refs: rename some parameters result -> sha1 mhagger
2011-10-13 18:42 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 05/14] clear_ref_list(): rename from free_ref_list() mhagger
2011-10-13 18:43 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 06/14] resolve_gitlink_ref(): improve docstring mhagger
2011-10-13 18:48 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 07/14] is_refname_available(): remove the "quiet" argument mhagger
2011-10-13 12:41 ` Drew Northup
2011-10-13 18:49 ` Junio C Hamano
2011-10-14 5:35 ` Michael Haggerty
2011-10-13 7:58 ` [PATCH 08/14] parse_ref_line(): add docstring mhagger
2011-10-13 7:58 ` [PATCH 09/14] add_ref(): " mhagger
2011-10-13 7:58 ` [PATCH 10/14] is_dup_ref(): extract function from sort_ref_list() mhagger
2011-10-13 20:43 ` Junio C Hamano
2011-10-13 7:58 ` [PATCH 11/14] refs: change signatures of get_packed_refs() and get_loose_refs() mhagger
2011-10-13 7:58 ` [PATCH 12/14] get_ref_dir(): change signature mhagger
2011-10-13 7:58 ` [PATCH 13/14] Pass a (cached_refs *) to the resolve_gitlink_*() functions mhagger
2011-10-13 7:58 ` [PATCH 14/14] resolve_gitlink_ref_recursive(): change to work with struct cached_refs mhagger
2011-10-13 8:06 ` [PATCH] t1402-check-ref-format: skip tests of refs beginning with slash on Windows Johannes Sixt
2011-10-13 23:00 ` Junio C Hamano [this message]
2011-10-13 23:07 ` Junio C Hamano
2011-10-14 6:40 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfwiw33bf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=drew.northup@maine$(echo .)edu \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=j.sixt@viscovery$(echo .)net \
--cc=jnareb@gmail$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=julian@quantumfyre$(echo .)co.uk \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox