Subject: Re: [PATCH v2] git-rebase-interactive: do not squash commits on abort

From: Junio C Hamano <[email-masked]>
Date: Wed, 10 Sep 2008 15:36:34 -0700

Johannes Schindelin <[email-masked]> writes:

>> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
>> index 929d681..aaca915 100755
>> --- a/git-rebase--interactive.sh
>> +++ b/git-rebase--interactive.sh
>> @@ -427,14 +427,18 @@ do
>>  		else
>>  			. "$DOTEST"/author-script ||
>>  				die "Cannot find the author identity"
>> +			amend=""
>
> Sorry, my mistake... I should have been more explicit.  In most (if not 
> all) shell scripts, we prefer to set to the empty string with the 
> expression
>
> 			amend=

Don't worry.  I would notice and remove "" in my MUA for things like
these; especially the patch is this small it is hard to miss.