public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Robin Rosenberg <robin.rosenberg@dewire•com>
Cc: "Torsten Bögershausen" <tboegi@web•de>, git@vger•kernel.org
Subject: Re: [PATCH v9] git on Mac OS and precomposed unicode
Date: Thu, 26 Jul 2012 16:04:14 -0700	[thread overview]
Message-ID: <7vhasu5dld.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <5011AD4A.8060901@dewire.com> (Robin Rosenberg's message of "Thu, 26 Jul 2012 22:49:14 +0200")

Robin Rosenberg <robin.rosenberg@dewire•com> writes:

> Just a couple of nitpicks.

Polishing is always good and better late than never, but for a topic
that has long been graduated to 'master' already, it would be easier
to review and discuss if it came as a patch form relative to the
codebase _after_ the topic has been applied.

Thanks.

  reply	other threads:[~2012-07-26 23:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-08 13:50 [PATCH v9] git on Mac OS and precomposed unicode Torsten Bögershausen
2012-07-26 20:49 ` Robin Rosenberg
2012-07-26 23:04   ` Junio C Hamano [this message]
2012-08-17  3:26     ` Junio C Hamano
2012-08-17 14:53       ` [PATCH] cleanup precompose_utf8 Robin Rosenberg
2012-08-17 17:20         ` Junio C Hamano
2012-08-17 17:30         ` Junio C Hamano
2012-08-19 17:10           ` Torsten Bögershausen
2012-08-20 18:13             ` [PATCH] precompose-utf8: do not call checks for non-ascii "utf8" Junio C Hamano
2012-08-20 19:46               ` Torsten Bögershausen
2012-08-20 22:02                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhasu5dld.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=robin.rosenberg@dewire$(echo .)com \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox