From: Junio C Hamano <junio@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jay Soffian <jaysoffian@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] add, merge, diff: do not use strcasecmp to compare config variable names
Date: Sat, 14 May 2011 18:53:29 -0700 [thread overview]
Message-ID: <7vhb8wrap2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110514201921.GA10758@elie> (Jonathan Nieder's message of "Sat, 14 May 2011 15:19:21 -0500")
Jonathan Nieder <jrnieder@gmail•com> writes:
> The config machinery already makes section and variable names
> lowercase when parsing them, so using strcasecmp for comparison just
> feels wasteful. No noticeable change intended.
A quick "grep 'strcasecmp(va*r*, "[^"]*\.' yields exactly the ones covered
by this patch.
Thanks, I've been meaning to change these while reading merge-recursive.
next prev parent reply other threads:[~2011-05-15 2:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 17:22 [PATCH] Add log.abbrev-commit config option Jay Soffian
2011-05-14 17:26 ` Jay Soffian
2011-05-14 19:01 ` Jonathan Nieder
2011-05-14 19:35 ` Jay Soffian
2011-05-14 20:19 ` [PATCH] add, merge, diff: do not use strcasecmp to compare config variable names Jonathan Nieder
2011-05-15 1:53 ` Junio C Hamano [this message]
2011-05-14 20:47 ` [PATCH v2] Add log.abbrevCommit config variable Jay Soffian
2011-05-14 21:55 ` Jonathan Nieder
2011-05-14 22:22 ` Jay Soffian
2011-05-14 22:49 ` [PATCH v3] " Jay Soffian
2011-05-15 13:25 ` Jay Soffian
2011-05-15 22:42 ` Junio C Hamano
2011-05-16 5:53 ` Jay Soffian
2011-05-16 7:00 ` Jonathan Nieder
2011-05-16 7:18 ` Jay Soffian
2011-05-17 17:03 ` Junio C Hamano
2011-05-17 21:50 ` Junio C Hamano
2011-05-18 1:05 ` Jay Soffian
2011-05-17 18:50 ` Junio C Hamano
2011-05-17 19:08 ` Jay Soffian
2011-05-15 1:48 ` [PATCH] Add log.abbrev-commit config option Junio C Hamano
2011-05-16 8:24 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhb8wrap2.fsf@alter.siamese.dyndns.org \
--to=junio@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jaysoffian@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox