From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Michal Nazarewicz <mpn@google•com>,
Ted Zlatanov <tzz@lifelogs•com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
git@vger•kernel.org
Subject: Re: [PATCH 2/4] Git.pm: Allow pipes to be closed prior to calling command_close_bidi_pipe
Date: Wed, 06 Feb 2013 16:14:15 -0800 [thread overview]
Message-ID: <7vip659e08.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130206230406.GK27507@sigill.intra.peff.net> (Jeff King's message of "Wed, 6 Feb 2013 18:04:06 -0500")
Jeff King <peff@peff•net> writes:
> On Wed, Feb 06, 2013 at 09:47:04PM +0100, Michal Nazarewicz wrote:
>
>> From: Michal Nazarewicz <mina86@mina86•com>
>>
>> The command_close_bidi_pipe() function will insist on closing both
>> input and output pipes returned by command_bidi_pipe(). With this
>> change it is possible to close one of the pipes in advance and
>> pass undef as an argument.
>>
>> This allows for something like:
>>
>> my ($pid, $in, $out, $ctx) = command_bidi_pipe(...);
>> print $out "write data";
>> close $out;
>> # ... do stuff with $in
>> command_close_bidi_pipe($pid, $in, undef, $ctx);
>
> Should this part go into the documentation for command_close_bidi_pipe
> in Git.pm?
Yeah, it probably should.
next prev parent reply other threads:[~2013-02-07 0:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 20:47 [PATCH 0/4] Make git-send-email git-credential Michal Nazarewicz
2013-02-06 20:47 ` [PATCH 1/4] Git.pm: Allow command_close_bidi_pipe() to be called as method Michal Nazarewicz
2013-02-06 20:47 ` [PATCH 2/4] Git.pm: Allow pipes to be closed prior to calling command_close_bidi_pipe Michal Nazarewicz
2013-02-06 23:04 ` Jeff King
2013-02-07 0:14 ` Junio C Hamano [this message]
2013-02-06 20:47 ` [PATCH 3/4] Git.pm: Add interface for git credential command Michal Nazarewicz
2013-02-06 23:16 ` Jeff King
2013-02-07 7:19 ` Matthieu Moy
2013-02-07 7:22 ` Matthieu Moy
2013-02-06 20:47 ` [PATCH 4/4] git-send-email: Use git credential to obtain password Michal Nazarewicz
2013-02-06 23:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vip659e08.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=mpn@google$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=tzz@lifelogs$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox