From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: szager@google•com, git@vger•kernel.org, sop@google•com, daniel@haxx•se
Subject: Re: Fix potential hang in https handshake (v3)
Date: Fri, 19 Oct 2012 14:21:59 -0700 [thread overview]
Message-ID: <7vipa6i2dk.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121019210851.GD24184@sigill.intra.peff.net> (Jeff King's message of "Fri, 19 Oct 2012 17:08:51 -0400")
Jeff King <peff@peff•net> writes:
>> + if (max_fd < 0 &&
>> + select_timeout.tv_sec > 0 ||
>> + select_timeout.tv_usec > 50000) {
>> + select_timeout.tv_sec = 0;
>> + select_timeout.tv_usec = 50000;
>> + }
>
> Should there be parentheses separating the || bit from the &&?
Yeah, I think there should be. Thanks for sharp eyes.
prev parent reply other threads:[~2012-10-19 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 21:04 Fix potential hang in https handshake (v3) szager
2012-10-19 21:08 ` Jeff King
2012-10-19 21:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipa6i2dk.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=daniel@haxx$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sop@google$(echo .)com \
--cc=szager@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox