public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Michael Haggerty <haggerty@jpk•com>,
	git discussion list <git@vger•kernel.org>
Subject: Re: t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids
Date: Thu, 24 May 2012 17:08:15 -0700	[thread overview]
Message-ID: <7vipflunps.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120524232515.GA11054@sigill.intra.peff.net> (Jeff King's message of "Thu, 24 May 2012 19:25:15 -0400")

Jeff King <peff@peff•net> writes:

> On Thu, May 24, 2012 at 04:15:53PM -0400, Jeff King wrote:
>
>> > If you mean "why environment and not an API call?", then I would have to
>> > agree.  ident_committer_email() call, that returns a sanitized version,
>> > would have been a natural way to write this, if it were available.
>> 
>> I meant the latter. There is no such call, but I can make one. Let me
>> see how awkward it is.
>
> Here it is.
>
>   [1/7]: ident: refactor empty ident error message
>
> This one is only tangentially related. I was going to touch the message
> more in patch 3, but decided not to (details in that patch).
>
>   [2/7]: ident: refactor NO_DATE flag in fmt_ident
>   [3/7]: ident: let callers omit name with fmt_indent
>   [4/7]: format-patch: use GIT_COMMITTER_EMAIL in message ids
>
> These ones should fix Michael's failing test and restore the original
> behavior.
>
>   [5/7]: ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT
>   [6/7]: ident: reject bogus email addresses with IDENT_STRICT
>   [7/7]: format-patch: do not use bogus email addresses in message ids
>
> These ones prevent bogus message ids from being generated at all
> (which is an improvement over the previous state).

All looked pretty straightforward and cleanly done.

We might want to further tighten 6/7 to verify user-supplied (i.e. non
default) e-mail for sanity, as I agree with the comment below --- lines of
that patch.

Also the check might want to be further tightened in the RFC 822/2822/5322
sense, but getting it correct will open a huge can of worms; I think the
check in 6/7 is a good place to stop, at least for now.

Thanks.

next prev parent reply	other threads:[~2012-05-25  0:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 12:01 t4014 broken by 43ae9f47ab: format-patch: use default email for generating message ids Michael Haggerty
2012-05-24 17:16 ` Jeff King
2012-05-24 20:07   ` Junio C Hamano
2012-05-24 20:15     ` Jeff King
2012-05-24 23:25       ` Jeff King
2012-05-24 23:26         ` [PATCH 1/7] ident: refactor empty ident error message Jeff King
2012-05-24 23:26         ` [PATCH 2/7] ident: refactor NO_DATE flag in fmt_ident Jeff King
2012-05-24 23:27         ` [PATCH 3/7] ident: let callers omit name with fmt_indent Jeff King
2012-05-24 23:28         ` [PATCH 4/7] format-patch: use GIT_COMMITTER_EMAIL in message ids Jeff King
2012-05-24 23:28         ` [PATCH 5/7] ident: rename IDENT_ERROR_ON_NO_NAME to IDENT_STRICT Jeff King
2012-05-24 23:32         ` [PATCH 6/7] ident: reject bogus email addresses with IDENT_STRICT Jeff King
2012-05-24 23:32         ` [PATCH 7/7] format-patch: do not use bogus email addresses in message ids Jeff King
2012-05-25  0:08         ` Junio C Hamano [this message]
2012-05-25  0:34           ` t4014 broken by 43ae9f47ab: format-patch: use default email for generating " Jeff King
2012-05-24 20:49   ` Michael Haggerty
2012-05-24 21:02     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vipflunps.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=haggerty@jpk$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox