public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jeremy White <jwhite@codeweavers•com>
Cc: git@vger•kernel.org
Subject: Re: [Virtual PATCH] Add an option to wrap a patch in <pre> in git-imap-send which ironically results in a cleaner patch from Thunderbird.
Date: Thu, 12 Feb 2009 20:19:54 -0800	[thread overview]
Message-ID: <7viqnfezo5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <499446D0.90602@codeweavers.com> (Jeremy White's message of "Thu, 12 Feb 2009 09:57:04 -0600")

I do not think of a reason, other than to trigger the workaround you
mentioned in the documentation part of the patch, why any sane user would
want to send a patch as HTML.  This configuration variable sounds more
like "imap.forceThunderbirdToSendNonFlowedTextByExploitingItsBug" than
"imap.html", in other words.

What worries me the most is if there is any guarantee that this bug you
are exploiting to force it to send a patch in the common denominator
format _will not be fixed_ in future versions of Thunderbird.

I see your patch deals only with ampersand, less-than, greater-than and
dquot.  Do you know if this is enough, or would letters outside US-ASCII
need to be expressed in ampersand-hash "character reference" notation?

  reply	other threads:[~2009-02-13  4:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 15:57 [Virtual PATCH] Add an option to wrap a patch in <pre> in git-imap-send which ironically results in a cleaner patch from Thunderbird Jeremy White
2009-02-13  4:19 ` Junio C Hamano [this message]
2009-02-13 11:24   ` Michael J Gruber
2009-02-13 13:50     ` Jeremy White
2009-02-13 14:47       ` Ben Bucksch
2009-02-13 17:49     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqnfezo5.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jwhite@codeweavers$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox