From: Junio C Hamano <gitster@pobox•com>
To: Jakub Narebski <jnareb@gmail•com>
Cc: "Devin Doucette" <devin@doucette•cc>,
git@vger•kernel.org, "Petr Baudis" <petr.baudis@novartis•com>
Subject: Re: [PATCH] gitweb: Fix export check in git_get_projects_list
Date: Sat, 27 Dec 2008 22:54:36 -0800 [thread overview]
Message-ID: <7vk59kaixf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200812280312.02615.jnareb@gmail.com> (Jakub Narebski's message of "Sun, 28 Dec 2008 03:12:01 +0100")
Jakub Narebski <jnareb@gmail•com> writes:
> On Sat, 27 Dec 2008, Devin Doucette wrote:
>
>> When $filter was empty, the path passed to check_export_ok would
>> contain an extra '/', which some implementations of export_auth_hook
>> are sensitive to.
>>
>> It makes more sense to fix this here than to handle the special case
>> in each implementation of export_auth_hook.
>>
>> Signed-off-by: Devin Doucette <devin@doucette•cc>
>
> Good catch. Thanks.
Thanks, both. Will queue for 'maint'.
next prev parent reply other threads:[~2008-12-28 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 9:39 [PATCH] gitweb: Fix export check in git_get_projects_list Devin Doucette
2008-12-28 2:12 ` Jakub Narebski
2008-12-28 6:54 ` Junio C Hamano [this message]
2008-12-29 12:29 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk59kaixf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=devin@doucette$(echo .)cc \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=petr.baudis@novartis$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox