From: Junio C Hamano <gitster@pobox•com>
To: Lea Wiemann <lewiemann@gmail•com>
Cc: Miklos Vajna <vmiklos@frugalware•org>, git@vger•kernel.org
Subject: Re: [PATCH v3] perl/Git.pm: add parse_rev method
Date: Sun, 01 Jun 2008 21:59:26 -0700 [thread overview]
Message-ID: <7vk5h8a0up.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <484327FB.8080105@gmail.com> (Lea Wiemann's message of "Mon, 02 Jun 2008 00:51:39 +0200")
Lea Wiemann <lewiemann@gmail•com> writes:
> Miklos Vajna wrote:
>> Lea Wiemann <lewiemann@gmail•com> wrote:
>>> Is there *any* name for the identifiers you pass into git-rev-parse
>>> (like HEAD^2 or master:test/foo.txt)?
>>
>> `man git-rev-parse` calls them "revisions". Yes, even the commit:path
>> ones.
>
> True -- it's quite cringeworthy indeed. ;) As long as it only affects
> the documentation for that particular method, I'll go with "revision".
I think that is sensible, and the method can stay parse_rev, not get_hash,
don't you think?
next prev parent reply other threads:[~2008-06-02 5:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 4:43 [PATCH] perl/Git.pm: add rev_parse method Lea Wiemann
2008-05-30 7:03 ` Lea Wiemann
2008-05-30 9:59 ` Petr Baudis
2008-05-30 15:15 ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Lea Wiemann
2008-05-30 23:20 ` Merging strategy for extending Git.pm Junio C Hamano
2008-05-31 11:38 ` Merging strategy for extending Git.pm (was: [PATCH] perl/Git.pm: add rev_parse method) Johannes Schindelin
2008-05-31 12:42 ` Merging strategy for extending Git.pm Lea Wiemann
2008-05-31 12:52 ` Johannes Schindelin
2008-05-30 20:28 ` [PATCH] perl/Git.pm: add rev_parse method Junio C Hamano
2008-05-30 9:50 ` Petr Baudis
2008-05-30 20:27 ` [PATCH] perl/Git.pm: add parse_rev method Lea Wiemann
2008-05-30 21:05 ` Petr Baudis
2008-05-30 21:25 ` Junio C Hamano
2008-05-30 21:44 ` Randal L. Schwartz
2008-05-30 21:59 ` Lea Wiemann
2008-05-30 22:03 ` Randal L. Schwartz
2008-05-30 22:05 ` Lea Wiemann
2008-05-30 22:19 ` Junio C Hamano
2008-05-31 11:50 ` Johannes Schindelin
2008-05-31 12:17 ` Support for old Perl versions Petr Baudis
2008-05-31 12:32 ` Johannes Schindelin
2008-05-30 21:49 ` [PATCH] perl/Git.pm: add parse_rev method Petr Baudis
2008-05-31 13:52 ` [PATCH v2] " Lea Wiemann
2008-06-01 3:17 ` [PATCH v3] " Lea Wiemann
2008-06-01 3:17 ` Lea Wiemann
2008-06-01 17:38 ` Lea Wiemann
2008-06-01 21:54 ` Miklos Vajna
2008-06-01 22:51 ` Lea Wiemann
2008-06-02 4:59 ` Junio C Hamano [this message]
2008-06-02 13:51 ` Lea Wiemann
2008-06-01 23:09 ` [PATCH v4] perl/Git.pm: add get_hash method Lea Wiemann
2008-06-01 23:24 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5h8a0up.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=lewiemann@gmail$(echo .)com \
--cc=vmiklos@frugalware$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox