From: Junio C Hamano <gitster@pobox•com>
To: "Avery Pennarun" <apenwarr@gmail•com>
Cc: "Eduard - Gabriel Munteanu" <eduard.munteanu@linux360•ro>,
ryan@michonline•com, git@vger•kernel.org
Subject: Re: [PATCH] Added --export option to git-send-email.
Date: Sun, 13 Jul 2008 15:44:29 -0700 [thread overview]
Message-ID: <7vlk05o14i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <32541b130807131521w79cbf23m5934678e68312798@mail.gmail.com> (Avery Pennarun's message of "Sun, 13 Jul 2008 18:21:05 -0400")
"Avery Pennarun" <apenwarr@gmail•com> writes:
> And it's the MDA's job to munge it, not the MTA, so the
> lines should never be munged while in transit *to* ...
Yeah, you're right. Sending side should not have any issues like that.
My receiving end (I think fetchmail slurps from my ISP and drops mails in
my local mbox, but it's a long time ago I configured my system...) does
quote only the "From " at the beginning, which is consistent with the
traditional mbox behaviour, so I see one, one, two, three in my local
mbox, and zero, one, two, three on gmane news article.
If this additional option claims to produce a mbox, I think:
(1) quoting only /^From / (not /^>*From/) to be consistent with the
standard practice is the right thing to do; and
(2) reading side might need to also pay attention to /^>From /, in case
somebody feeds an output from this option back to send-email.
However, strictly speaking,(2) may break the standard workflow of
generating patches with format-patch and feeding the result to send-email,
as format-patch does not do /^From / munging (and it shouldn't). The
issue is mostly theoretical --- it only matters if your commit log has a
line that begins with ">From ", and people who have worked with e-mail for
any nontrivial period have already learned to reword their sentences to
avoid lines that begin with "From " (or ">From ", for that matter) anyway.
next prev parent reply other threads:[~2008-07-13 22:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 14:07 [PATCH] Added --export option to git-send-email Eduard - Gabriel Munteanu
2008-07-11 7:03 ` Junio C Hamano
2008-07-11 19:53 ` Eduard - Gabriel Munteanu
2008-07-13 20:17 ` Junio C Hamano
2008-07-13 21:32 ` Avery Pennarun
2008-07-13 21:36 ` Junio C Hamano
2008-07-13 21:44 ` Avery Pennarun
2008-07-13 22:05 ` Junio C Hamano
2008-07-13 22:21 ` Avery Pennarun
2008-07-13 22:44 ` Junio C Hamano [this message]
2008-07-13 23:42 ` Avery Pennarun
2008-07-13 23:58 ` Eduard - Gabriel Munteanu
2008-07-14 3:13 ` Junio C Hamano
2008-07-14 3:41 ` Avery Pennarun
2008-07-14 0:05 ` Eduard - Gabriel Munteanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlk05o14i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=apenwarr@gmail$(echo .)com \
--cc=eduard.munteanu@linux360$(echo .)ro \
--cc=git@vger$(echo .)kernel.org \
--cc=ryan@michonline$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox