Subject: Re: [PATCH v2 04/13] Teach rebase interactive the mark command

From: Junio C Hamano <[email-masked]>
Date: Tue, 22 Apr 2008 11:04:03 -0700

Jörg Sommer <[email-masked]> writes:

> What do you think about this version:
>
> cleanup_before_quit () {
> 	rm -rf "$DOTEST" &&
> 	for ref in $(git for-each-ref --format='%(refname)' ${mark_prefix%/})
> 	do
> 		git update-ref -d "$ref" "$ref" || return 1
> 	done
> }

Yeah, except you would want to dqquote "${mark_prefix%/}" part.

Also this being a "clean-up" phase, I wonder if we want to stop at the
first error (e.g. should unremovable "$DOTEST" leave marks behind?  should
unremovable one mark leave other marks that happen to sort after it
behind?).