From: Junio C Hamano <gitster@pobox•com>
To: Phil Hord <phil.hord@gmail•com>
Cc: Phil Hord <hordp@cisco•com>,
"git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH] Make is_gitfile a non-static generic function
Date: Wed, 12 Oct 2011 11:08:17 -0700 [thread overview]
Message-ID: <7vmxd69j72.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABURp0p4_oVMmkFDPue4kvhO_bEr_dBh-XFGArdSJFMz-Eboeg@mail.gmail.com> (Phil Hord's message of "Wed, 12 Oct 2011 14:01:02 -0400")
Phil Hord <phil.hord@gmail•com> writes:
> On Tue, Oct 11, 2011 at 7:45 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> After looking at this patch and the way the other caller in transport.c
>> uses it, I am more and more convinced that "is_gitfile()" is a stupid and
>> horrible mistake.
>
> I think I misunderstood your objection before. Now I think I
> understand. Tell me if I am right.
>
>
> I think you mean that instead of this:
> } else if (is_local(url) && is_file(url) && !is_gitfile(url)) {
>
> you would like to see this:
> } else if (is_local(url) && is_file(url) && is_bundle(url)) {
>
> Or maybe even this:
> } else if (is_bundle(url)) {
Exactly.
next prev parent reply other threads:[~2011-10-12 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E94C70E.3080003@cisco.com>
2011-10-11 22:52 ` [PATCH] Make is_gitfile a non-static generic function Phil Hord
2011-10-11 23:26 ` Junio C Hamano
2011-10-11 23:45 ` Junio C Hamano
2011-10-12 13:29 ` Phil Hord
2011-10-12 18:01 ` Phil Hord
2011-10-12 18:08 ` Junio C Hamano [this message]
2011-10-12 19:47 ` Phil Hord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxd69j72.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hordp@cisco$(echo .)com \
--cc=phil.hord@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox